Skip to content

[New] GET /managed/stats #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2019

Conversation

hzoppetti
Copy link
Contributor

Added GET /managed/stats endpoint.

Copy link
Contributor

@andystevensname andystevensname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just marked two things that we can discuss further.

openapi.yaml Outdated
- Managed
summary: List Managed Stats
description: |
Returns a list of Managed Stats on your Account in the form of y and x graph data points.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to either explain what the x and y points are (and put them in x, y order instead of y, x cause it's confusing that way), or just say something like:

Returns a list of Managed Stats on your Account. These stats reflect the last 24...

Either way works for me.

openapi.yaml Outdated
Comment on lines 16559 to 16570
y:
type: integer
readOnly: true
description: >
A stats graph data point.
example: 29.94
x:
type: integer
readOnly: true
description: >
A stats graph data point.
example: 11513761600000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would switch the order of these. People naturally want to see x before y, regardless of how they are returned in the api.

@hzoppetti hzoppetti requested a review from yoshizzle October 3, 2019 14:59
@andystevensname andystevensname merged commit 11087cb into linode:development Oct 4, 2019
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Create Changelogs “cloud-manager-0-82-0”
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants