[Update] POST /account/credit-card #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshizzle
approved these changes
Nov 4, 2019
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Adding changelog for cloud release 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove format for card_number:
The former
PANformat does not correspond to any format specified by OpenAPI:https://swagger.io/specification/#data-types
PANwas meant to stand forprimary account number, but this may not be obvious to an API reader.https://en.wikipedia.org/wiki/Payment_card_number
The format was meant to hide the number when using the CLI:
2bb2cc1
However, this functionality was never built into the CLI. After discussing with dev team, it's likely not desirable to have this functionality for the card_number property in the CLI. Because the
PANlabel doesn't assist with a reader's understanding of what the field should be used for, or the values it accepts, I'm proposing we remove it.