Skip to content

Cleaned up LKE Cluster Create endpoint #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

Dorthu
Copy link
Collaborator

@Dorthu Dorthu commented Nov 19, 2019

The CLI didn't like how the spec was formatted initially, and I'm pretty
sure it was wrong. This works with the linked CLI PR, but please verify
it looks good in the docs - I'm happy to work with someone to get this
into a mergable state.

The CLI didn't like how the spec was formatted initially, and I'm pretty
sure it was wrong.  This works with the linked CLI PR, but please verify
it looks good in the docs - I'm happy to work with someone to get this
into a mergable state.
@leslitagordita
Copy link
Contributor

leslitagordita commented Nov 20, 2019

  • Thanks for this update, @Dorthu . node_pools is certainly a list of objects. That was an error on my part.
  • I originally had node_pools as a property directly in the POST /lke/clusters request body, and not in the LKEClusterRequestBody. Ifnode_pools is in the LKEClusterRequestBody then node_pools is also displayed in the response for other endpoints:
    • POST /lke/clusters
    • GET /lke/clusters
    • GET /lke/clusters/{clusterId}
    • PUT /lke/clusters/{clusterId}
  • If you think it is more correct to have all properties in a component schema object, I can create a third schema object for all LKE cluster's common properties and convert LKECluster to LKEClusterResponse OR
  • Move node_pools back to POST /lke/clusters request body, but of course keep your update to its datatype.
  • OR is there a third thing I'm completely not considering?

@Dorthu
Copy link
Collaborator Author

Dorthu commented Nov 21, 2019

Let me move it back to where it was originally and see if the CLI will still use it - that's probably the right place for it.

@Dorthu
Copy link
Collaborator Author

Dorthu commented Nov 21, 2019

@leslitagordita fixed the placement of node_pools - cli still likes it.

@leslitagordita leslitagordita merged commit 05bc59e into linode:development Dec 2, 2019
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Create Changelogs “4-59-2-2020-03-10”
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants