Skip to content

[Update] LKENodePool to use multi-item example #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

leslitagordita
Copy link
Contributor

This example better represents the linodes property which returns an array of objects.

This example better represents the `linodes` property
which returns an array of objects.
@leslitagordita
Copy link
Contributor Author

leslitagordita commented Nov 27, 2019

Note: This requires a front end fix before it can be merged in.

@displague
Copy link
Contributor

displague commented Dec 2, 2019

An id: null example would also be useful to see.

@alioso
Copy link
Contributor

alioso commented Mar 18, 2021

hi @leslitagordita ! I found out I am still assigned this review :) can we please close this?

LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Copy link
Contributor

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be closed.

@displague
Copy link
Contributor

Yes, this PR offers an example for the linodes field in the LKENodePool schema.
The example is now present through the LKENodeStatus schema property examples.
This schema is embedded in the nodes property which replaced the linodes property in the OAS3 definition.

@displague
Copy link
Contributor

displague commented Apr 19, 2023

However, if it is still possible for an id to be null, that is a case that is not documented in the spec or the examples.

@bbiggerr bbiggerr closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants