Allow CLI to accept k8s version when creating clusters #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for linode/linode-cli#177 Right now, the "version" argument accepted when creating an LKE Cluster translates in the CLI to `--version`, which the CLI interprets to mean it should print its own version and exit. For this reason, a new spec extension has been added, `x-linode-cli-name`, which is allowed in schemas to define a new name for the CLI argument for any POST/PUT attribute. To keep things consistent between the API and CLI, this should be used only in extreme circumstances (such as noted above).
|
@Dorthu when I test this locally (building the linode-cli from master), I receive an error: |
|
Yeah, sorry, the associated CLI PR was closed because I'd already fixed this issue a different way 🙃 I'll close this as well. |
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for linode/linode-cli#177
Right now, the "version" argument accepted when creating an LKE Cluster
translates in the CLI to
--version, which the CLI interprets to meanit should print its own version and exit.
For this reason, a new spec extension has been added,
x-linode-cli-name, which is allowed in schemas to define a new namefor the CLI argument for any POST/PUT attribute. To keep things
consistent between the API and CLI, this should be used only in extreme
circumstances (such as noted above).