-
Notifications
You must be signed in to change notification settings - Fork 69
new: Added PUT /managed/services/$id #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/data/endpoints/managed.yaml
Outdated
"address": "http://monitor2.example.org", | ||
"timeout": 60, | ||
"consultation_group": "DevOps", | ||
"region": "us-east-1a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can region be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, if it's a private IP for address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
region should be null in this example
src/data/endpoints/managed.yaml
Outdated
"address": "http://monitor2.example.org", | ||
"timeout": 60, | ||
"consultation_group": "DevOps", | ||
"region": "us-east-1a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
region should be null in this example
44919b3
to
1f8d1ec
Compare
added change @jamesottinger asked for regarding null region in the example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
new: adds NodeBalancer transfer JSON
Modified libs/tools to reflect correct origin, added new lib
Display Endpoint Menu on Mobile
No description provided.