Skip to content

[Update] LKE collection property version to k8s_version #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leslitagordita
Copy link
Contributor

No description provided.

openapi.yaml Outdated
@@ -15756,8 +15756,7 @@ components:
x-linode-filterable: true
x-linode-cli-display: 3
example: us-central
version:
x-linode-filterable: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled in #237

Copy link
Contributor

@adammohammed adammohammed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the filterable changes can probably be removed if merged along with #237. Should we point this at the lke-ga-release-prep branch?

@leslitagordita leslitagordita changed the base branch from development to lke-ga-release-prep April 9, 2020 16:59
@leslitagordita
Copy link
Contributor Author

leslitagordita commented Apr 9, 2020

Yes! Just pointed it at the feature branch and was thinking the same thing. Your PR #237 will handle the removal of the other filterable properties. Thank you!

@leslitagordita
Copy link
Contributor Author

CC: @asauber, @Dorthu <- for release alignment purposes

@leslitagordita leslitagordita merged commit 9460361 into linode:lke-ga-release-prep Apr 9, 2020
@asauber
Copy link
Contributor

asauber commented Apr 9, 2020

Thank you @leslitagordita. Yes, we will want to do linode-cli release, as soon as the current hotfix is in prod.

LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants