Skip to content

New: /account/logins endpoints #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2020

Conversation

nmelehan
Copy link
Contributor

No description provided.

@nmelehan nmelehan requested a review from yoshizzle June 26, 2020 15:27
openapi.yaml Outdated
summary: View Login
description: >
Returns a login object that displays information about a successful
login from an arbitrary user on the account. This command can only be
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolute nitpick here. "Arbitrary" user sounds weird to me, almost implying that the user isn't directly tied to the login object identified by the id.

It's a non-breaking thought, so if you feel like it stands well as-is then I'm all for it.

Copy link
Contributor Author

@nmelehan nmelehan Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean... maybe an alternative could be:

Returns a Login object that displays information about a successful login. The logins that can be viewed can be for any user on the account, and are not limited to only the logins of the user that is accessing this API endpoint. This command can only be accessed by the unrestricted users of the account.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works for me

@nmelehan nmelehan merged commit 58bd928 into linode:development Jun 28, 2020
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants