Added more robust language to kvmify #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More explicit language denoting that you can only kvmify if your Linode is currently Xen.
Dorthu
requested changes
Jan 4, 2018
src/data/endpoints/linodes.yaml
Outdated
| @@ -655,7 +655,8 @@ endpoints: | |||
| type: Action | |||
| authenticated: true | |||
| description: > | |||
| Changes a Linode's hypervisor from Xen to KVM. | |||
| Changes a Linode's hypervisor from Xen to KVM. This endpoint can only be | |||
| used if your Linode is currently Xen and you wish to move to KVM. | |||
There was a problem hiding this comment.
Might be worth including more info on what KVM and Xen are, and why the upgrade is desirable? Something like
Changes a Linode's hypervisor from Xen (legacy) to KVM (modern). Doing this restarts and migrates the Linode, and can take several minutes depending on the size of the Linode. Upgrading to KVM has significant performances improvements, including a 300% boost in Unixbench scores and faster boots and shutdowns. This endpoint will only work for Linodes running on the Xen hypervisor.
Dorthu
approved these changes
Jan 4, 2018
jamesottinger
suggested changes
Jan 4, 2018
src/data/endpoints/linodes.yaml
Outdated
| @@ -655,7 +655,11 @@ endpoints: | |||
| type: Action | |||
| authenticated: true | |||
| description: > | |||
| Changes a Linode's hypervisor from Xen to KVM. | |||
| Changes a Linode's hypervisor from Xen (legacy) to KVM (modern). Doing this | |||
| restarts and migrates your Linode, and take several minutes depending on | |||
jamesottinger
approved these changes
Jan 4, 2018
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Changed CLI links to point to GitHub repo
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
DLC-163 format content to retain underscores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More explicit language denoting that you can only kvmify if your Linode
is currently Xen.