-
Notifications
You must be signed in to change notification settings - Fork 69
[Update] Limited access keys with Object Storage #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update] Limited access keys with Object Storage #318
Conversation
openapi.yaml
Outdated
@@ -10692,6 +10692,22 @@ paths: | |||
type: string | |||
description: The label for this keypair, for display purposes only. | |||
example: my-key | |||
bucket_access: | |||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be type: array
with items
being of type: object
and having the properties you added below. Same for the response value below.
openapi.yaml
Outdated
example: ap-south-1 | ||
bucket_name: | ||
type: string | ||
description: The unique label of the bucket with limited access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unique label of the bucket to which the key should have access.
openapi.yaml
Outdated
example: example-bucket | ||
permissions: | ||
type: string | ||
description: The permissions for the selected key. Can be `read_write` or `read_only`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The permissions of the key for the selected bucket.
openapi.yaml
Outdated
properties: | ||
cluster: | ||
type: string | ||
description: The datacenter where a bucket with limited access is hosted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be more accurate to say The Object Storage cluster where a bucket to which the key should have access is hosted.
The OBJ cluster label is different than the datacenter/region label (typically just a -1
appended to the datacenter name.)
type: boolean | ||
description: Whether or not this key is a limited access key. Will return `false` if this key grants full access to all buckets on the user's account. | ||
example: true | ||
bucket_access: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My other comments about type and property descriptions also apply to this section.
update limited field to be readOnly
Add enum for permissions field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy changes look good 👍
Add changelog for LKE release 1.12.1
No description provided.