-
Notifications
You must be signed in to change notification settings - Fork 69
Hotfix 4.76.1 #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix 4.76.1 #336
Conversation
leslitagordita
commented
Sep 23, 2020
- Bumps spec to 4.76.1
- Includes new feature BYO Object Storage SSL Cert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change in the shell example.
Co-authored-by: Adam Mohammed <[email protected]>
@adammohammed thank you! |
openapi.yaml
Outdated
source: > | ||
linode-cli object-storage ssl-upload \ | ||
us-east-1 example-bucket \ | ||
--certificate """-----BEGIN CERTIFICATE-----MIIDbDCCAlQCCQCl-----END CERTIFICATE-----""" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we duplicate those changes here
openapi.yaml
Outdated
type: string | ||
description: > | ||
The private key associated with this SSL certificate. | ||
example: RwtqMlXveYH531g770BBNluAk9s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-----BEGIN PRIVATE KEY-----
MIIEvgIBADANBgkqhkiG9w0BAQE
...
-----END PRIVATE KEY-----
openapi.yaml
Outdated
description: > | ||
Your Base64 encoded and PEM formatted SSL certificate. | ||
example: > | ||
"""-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop the triple quotes here.
Copy edits to reflect the change Info about replacing an expired certificate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you @leslitagordita
Changelogs for Cloud Manager v1.32.0 and JS client v0.43.0