-
Notifications
You must be signed in to change notification settings - Fork 69
VLANs and Interfaces Endpoints #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VLANs and Interfaces Endpoints #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left some minor comments
Now returns object with id, ipv4, and mac_address
e13e8d3
to
bcd454a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbiggerr I still need to go through the meat of this, but wanted to get this initial feedback to you ASAP. I'll dig into the copy tomorrow morning. Lemme know if you have questions. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add something about how adding/changing/removing interfaces is not sufficient by itself to make those changes happen on the linode? A reboot (or other workflow that causes the linode to be booted/restarted) is required for the networking changes to actually take effect. This gives customers the flexibility to make those changes and then have them take effect when convenient for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same comments as Carissa. The other things have been addressed.
Add API v4.86.0 changelog
Uh oh!
There was an error while loading. Please reload this page.