Skip to content

VLANs and Interfaces Endpoints #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leslitagordita
Copy link
Contributor

@leslitagordita leslitagordita commented Oct 7, 2020

  • VLANs List
  • Linode Create (new interface field)
  • Configuration Profile Create (new interface field)
  • Configuration Profile Update (new interface field)

Copy link

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some minor comments

@bbiggerr bbiggerr force-pushed the vlans-and-interfaces-endpoints branch from e13e8d3 to bcd454a Compare March 31, 2021 16:13
@bbiggerr bbiggerr requested review from alsaihn and yoshizzle and removed request for aspsk March 31, 2021 16:15
Copy link
Collaborator

@yoshizzle yoshizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbiggerr I still need to go through the meat of this, but wanted to get this initial feedback to you ASAP. I'll dig into the copy tomorrow morning. Lemme know if you have questions. Thanks!

Copy link
Contributor

@alsaihn alsaihn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add something about how adding/changing/removing interfaces is not sufficient by itself to make those changes happen on the linode? A reboot (or other workflow that causes the linode to be booted/restarted) is required for the networking changes to actually take effect. This gives customers the flexibility to make those changes and then have them take effect when convenient for them.

Copy link
Collaborator

@yoshizzle yoshizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same comments as Carissa. The other things have been addressed.

@bbiggerr bbiggerr merged commit b58a994 into linode:development Apr 5, 2021
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants