Skip to content

[New] Service Transfers Endpoints #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

bbiggerr
Copy link
Contributor

@bbiggerr bbiggerr commented Mar 8, 2021

  • Add Service Transfers
  • Deprecate Entity Transfers

openapi.yaml Outdated
description: |
Returns the details of the Service Transfer for the provided token.

This command can only be accessed by the unrestricted users of the accounts that created or accepted this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a bit more clarification. If the transfer is pending, any unrestricted user may view it. This is because we don't know who the transfer is intended for. In any other state, only the creator/acceptor accounts' unrestricted users may view it.

Copy link
Contributor Author

@bbiggerr bbiggerr Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this clearer?
"Until a transfer is accepted, only unrestricted users of the account that created it can view it. After a transfer has been accepted, it can also be viewed by any unrestricted user of the account that accepted the transfer."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbiggerr Carissa means any unrestricted user at all. Meaning any user for any customer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:
"Until a transfer is accepted any unrestricted user may view it. After a transfer has been accepted, it can also be viewed by any unrestricted user of the account that created or accepted the transfer."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the clearest way to put it:

While a transfer is pending, any unrestricted user of any account can access this command. After a
transfer has been accepted, it can only be viewed by unrestricted users of the accounts that created and
accepted the transfer. If cancelled or expired, only unrestricted users of the account that created the
transfer can view it.

Copy link
Contributor

@alsaihn alsaihn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a clarifying change, but other than that it looks great!

Copy link
Collaborator

@yoshizzle yoshizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved once the suggested change from Carissa and me is addressed.

@bbiggerr bbiggerr merged commit 7563e7b into linode:development Mar 9, 2021
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants