Skip to content

new: Add POST /images #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RobertDeRose
Copy link
Contributor

No description provided.

@@ -20,6 +19,35 @@ endpoints:
python: |
import linode
TODO
POST:
money: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we don't charge for images

@@ -20,6 +19,35 @@ endpoints:
python: |
import linode
TODO
POST:
money: true
oauth: images:create
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also linodes:view ?

@RobertDeRose RobertDeRose force-pushed the feature/post-create-images branch from ea48426 to d54f3f1 Compare January 16, 2018 17:10
@RobertDeRose RobertDeRose changed the title [WIP] new: Add POST /images new: Add POST /images Jan 16, 2018
@yoshizzle
Copy link
Collaborator

Approved, but someone needs to kick tests again

limit: "1-50 ASCII characters limited to letters, numbers, and underscores"
value: this_is_a_label
description:
optioanl: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

@RobertDeRose RobertDeRose force-pushed the feature/post-create-images branch from d54f3f1 to 7e4086a Compare January 17, 2018 17:00
description: A longer summary that describes the image
type: String
limit: "1-65000 ASCII characters"
value: A longer description of the image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now you've got extra indentation here

optional: false
description: The id of the Linode Disk that should be imagized
type: Integer
value: 123
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too - I think these files are 2 spaces

Copy link
Collaborator

@Dorthu Dorthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is weird and inconsistent, but it's fine otherwise

@RobertDeRose RobertDeRose force-pushed the feature/post-create-images branch from 7e4086a to 5959291 Compare January 17, 2018 19:03
@RobertDeRose
Copy link
Contributor Author

@Dorthu all fixed... bad editor, I blame it on

@RobertDeRose RobertDeRose force-pushed the feature/post-create-images branch from 5959291 to 90dcc2d Compare January 17, 2018 19:10
@RobertDeRose RobertDeRose merged commit 19fd0a9 into linode:develop Jan 17, 2018
@RobertDeRose RobertDeRose deleted the feature/post-create-images branch January 17, 2018 19:15
alioso pushed a commit that referenced this pull request Aug 22, 2019
bug: Removed root_device_ro from LinodeConfig
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
[New] Add way to build the api docs site from a local spec file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants