Update NodeBalancer hostname #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshizzle
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
would check with @jfrederickson or @stvnjacobs to ensure this is a valid example.
alsaihn
reviewed
Dec 15, 2021
openapi.yaml
Outdated
| @@ -20248,8 +20248,8 @@ components: | |||
| hostname: | |||
| type: string | |||
| description: > | |||
| This NodeBalancer's hostname, ending with _.nodebalancer.linode.com_ | |||
| example: nb-207-192-68-16.newark.nodebalancer.linode.com | |||
| This NodeBalancer's hostname, ending with _.ip.linodeusercontent.com_ | |||
There was a problem hiding this comment.
Suggested change
| This NodeBalancer's hostname, ending with _.ip.linodeusercontent.com_ | |
| This NodeBalancer's IPv4 address, ending with _.ip.linodeusercontent.com_ |
There was a problem hiding this comment.
It's still correct to call this the hostname, it's just that the hostname is derived from the IPv4 address. (So were the previous ones.)
alsaihn
approved these changes
Dec 15, 2021
openapi.yaml
Outdated
| This NodeBalancer's hostname, ending with _.nodebalancer.linode.com_ | ||
| example: nb-207-192-68-16.newark.nodebalancer.linode.com | ||
| This NodeBalancer's hostname, ending with _.ip.linodeusercontent.com_ | ||
| example: 123-456-789-00.ip.linodeusercontent.com |
There was a problem hiding this comment.
Nitpick: that's not a valid IPv4 address, so this hostname could never be generated.
I would probably go with one of the IPs from a range reserved for documentation: https://datatracker.ietf.org/doc/html/rfc5737
LBGarber
pushed a commit
to LBGarber/linode-api-docs
that referenced
this pull request
Jun 15, 2022
Changelog for Cloud Manager v1.66.0, JS Client v0.71.0 and Validation v0.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.