bug: Add missing CLI commands/actions to operations #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the Linode CLI. In the current CLI release, we see this: ```bash wsmith@linode::linode-cli[master]$ linode-cli default --help linode-cli default [ACTION] Available actions: ┌──────────────────────┬────────────────────────┐ │ action │ summary │ ├──────────────────────┼────────────────────────┤ │ getEntityTransfers │ Entity Transfers List │ │ createEntityTransfer │ Entity Transfer Create │ │ getEntityTransfer │ Entity Transfer View │ │ deleteEntityTransfer │ Entity Transfer Cancel │ │ acceptEntityTransfer │ Entity Transfer Accept │ │ import │ Domain Import │ └──────────────────────┴────────────────────────┘ ``` These operations appear in "default" because they have no `x-linode-cli-command` defined in the spec (so they fall into the default command). This isn't ideal. Additionally, many of those commands are using their operationId as their action since they lack a `x-linode-cli-action` element. This change adds a command and action to all of the above.
alsaihn
approved these changes
Dec 28, 2021
bbiggerr
reviewed
Dec 28, 2021
|
I didn't realize these were renamed. I'll mark them as skipped instead. |
Dorthu
added a commit
to linode/linode-cli
that referenced
this pull request
Jan 4, 2022
Related to linode/linode-api-docs#581 It is possible that every operation in a path is skipped in the CLI via the `x-linode-cli-skip` spec extension. In this case, that path's command should not be present in the CLI at all, as it would have no actions associated to it. The above-linked PR introduces the first paths that are entirely skipped in this way. This change removes all empty commands from the CLI after building the entire command/action structure.
|
Opened an associated CLI PR to remove the "default" command from the CLI, which otherwise would be empty (as all operations in it were skipped) |
bbiggerr
approved these changes
Jan 10, 2022
lgarber-akamai
pushed a commit
to lgarber-akamai/linode-cli
that referenced
this pull request
Oct 26, 2022
Related to linode/linode-api-docs#581 It is possible that every operation in a path is skipped in the CLI via the `x-linode-cli-skip` spec extension. In this case, that path's command should not be present in the CLI at all, as it would have no actions associated to it. The above-linked PR introduces the first paths that are entirely skipped in this way. This change removes all empty commands from the CLI after building the entire command/action structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the Linode CLI.
In the current CLI release, we see this:
These operations appear in "default" because they have no
x-linode-cli-commanddefined in the spec (so they fall into thedefault command). This isn't ideal. Additionally, many of those
commands are using their operationId as their action since they lack a
x-linode-cli-actionelement.This change adds a command and action to all of the above.