Skip to content

ref: cleanup managed credential docs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

SzySteve
Copy link

@SzySteve SzySteve commented Dec 15, 2017

  • remove username and last_decrypted from the response
  • move /:id/password to /:id/update

screen shot 2017-12-15 at 11 37 41 am

screen shot 2017-12-15 at 11 38 03 am

* remove username and last_decrypted from the response
* move /:id/password to /:id/update
group: Credentials
type: resource
authenticated: true
description: >
Change the password for a credential.
Change the username and password for a credential.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do one or both, right? Should this read "username and/or password"?

methods:
POST:
response: ManagedCredential
description: >
Changes the password for a credential.
Changes the username and password for a credential.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, should this be "and/or" ?

password:
description: New password to set for this credential.
value: mypassword
type: String
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password is required but username isn't? That's ...weird 😕

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, but correct.

Copy link
Collaborator

@yoshizzle yoshizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Dorthu's assessment/request for changing to and/or.

If you can fix those two places I'll approve and merge.

@yoshizzle yoshizzle merged commit 8e60dc8 into linode:develop Dec 18, 2017
alioso pushed a commit that referenced this pull request Aug 22, 2019
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants