-
Notifications
You must be signed in to change notification settings - Fork 69
ref: cleanup managed credential docs #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: cleanup managed credential docs #8
Conversation
* remove username and last_decrypted from the response * move /:id/password to /:id/update
src/data/endpoints/managed.yaml
Outdated
group: Credentials | ||
type: resource | ||
authenticated: true | ||
description: > | ||
Change the password for a credential. | ||
Change the username and password for a credential. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do one or both, right? Should this read "username and/or password"?
src/data/endpoints/managed.yaml
Outdated
methods: | ||
POST: | ||
response: ManagedCredential | ||
description: > | ||
Changes the password for a credential. | ||
Changes the username and password for a credential. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, should this be "and/or" ?
password: | ||
description: New password to set for this credential. | ||
value: mypassword | ||
type: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
password is required but username isn't? That's ...weird 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, but correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @Dorthu's assessment/request for changing to and/or.
If you can fix those two places I'll approve and merge.
Design of changelog page
Uh oh!
There was an error while loading. Please reload this page.