drm/amdkfd: Remove unnecessary condition in kfd_topology_add_device()

error27 · alexdeucher · commit 7d4f8db4a144 · 2022-11-29T11:03:37.000-05:00
We re-arranged this code recently so "ret" is always zero at this point.

Signed-off-by: Dan Carpenter &lt;error27@gmail.com&gt;
Signed-off-by: Felix Kuehling &lt;Felix.Kuehling@amd.com&gt;
Reviewed-by: Felix Kuehling &lt;Felix.Kuehling@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -2012,10 +2012,9 @@ int kfd_topology_add_device(struct kfd_dev *gpu)
 
 	kfd_debug_print_topology();
 
-	if (!res)
-		kfd_notify_gpu_change(gpu_id, 1);
+	kfd_notify_gpu_change(gpu_id, 1);
 
-	return res;
+	return 0;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -2012,10 +2012,9 @@ int kfd_topology_add_device(struct kfd_dev *gpu)`
`2012`	`2012`
`2013`	`2013`	`kfd_debug_print_topology();`
`2014`	`2014`
`2015`		`- if (!res)`
`2016`		`- kfd_notify_gpu_change(gpu_id, 1);`
	`2015`	`+ kfd_notify_gpu_change(gpu_id, 1);`
`2017`	`2016`
`2018`		`- return res;`
	`2017`	`+ return 0;`
`2019`	`2018`	`}`
`2020`	`2019`
`2021`	`2020`	`/**`