Skip to content

Commit 8beee4d

Browse files
lxinPaolo Abeni
authored andcommitted
sctp: set sk_state back to CLOSED if autobind fails in sctp_listen_start
In sctp_listen_start() invoked by sctp_inet_listen(), it should set the sk_state back to CLOSED if sctp_autobind() fails due to whatever reason. Otherwise, next time when calling sctp_inet_listen(), if sctp_sk(sk)->reuse is already set via setsockopt(SCTP_REUSE_PORT), sctp_sk(sk)->bind_hash will be dereferenced as sk_state is LISTENING, which causes a crash as bind_hash is NULL. KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] RIP: 0010:sctp_inet_listen+0x7f0/0xa20 net/sctp/socket.c:8617 Call Trace: <TASK> __sys_listen_socket net/socket.c:1883 [inline] __sys_listen+0x1b7/0x230 net/socket.c:1894 __do_sys_listen net/socket.c:1902 [inline] Fixes: 5e8f3f7 ("sctp: simplify sctp listening code") Reported-by: [email protected] Signed-off-by: Xin Long <[email protected]> Acked-by: Marcelo Ricardo Leitner <[email protected]> Link: https://patch.msgid.link/a93e655b3c153dc8945d7a812e6d8ab0d52b7aa0.1727729391.git.lucien.xin@gmail.com Signed-off-by: Paolo Abeni <[email protected]>
1 parent c692964 commit 8beee4d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

net/sctp/socket.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8557,8 +8557,10 @@ static int sctp_listen_start(struct sock *sk, int backlog)
85578557
*/
85588558
inet_sk_set_state(sk, SCTP_SS_LISTENING);
85598559
if (!ep->base.bind_addr.port) {
8560-
if (sctp_autobind(sk))
8560+
if (sctp_autobind(sk)) {
8561+
inet_sk_set_state(sk, SCTP_SS_CLOSED);
85618562
return -EAGAIN;
8563+
}
85628564
} else {
85638565
if (sctp_get_port(sk, inet_sk(sk)->inet_num)) {
85648566
inet_sk_set_state(sk, SCTP_SS_CLOSED);

0 commit comments

Comments
 (0)