Skip to content

Commit a02d26f

Browse files
committed
Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue
Tony Nguyen says: ==================== 1GbE Intel Wired LAN Driver Updates 2020-07-27 This series contains updates to igc driver only. Sasha cleans up double definitions, unneeded and non applicable registers, and removes unused fields in structs. Ensures the Receive Descriptor Minimum Threshold Count is cleared and fixes a static checker error. v2: Remove fields from hw_stats in patches that removed their uses. Reworded patch descriptions for patches 1, 2, and 4. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 3540669 + 360d749 commit a02d26f

File tree

4 files changed

+2
-52
lines changed

4 files changed

+2
-52
lines changed

drivers/net/ethernet/intel/igc/igc_hw.h

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,7 @@ struct igc_mac_info {
8282

8383
enum igc_mac_type type;
8484

85-
u32 collision_delta;
86-
u32 ledctl_default;
87-
u32 ledctl_mode1;
88-
u32 ledctl_mode2;
8985
u32 mc_filter_type;
90-
u32 tx_packet_delta;
91-
u32 txcw;
9286

9387
u16 mta_reg_count;
9488
u16 uta_reg_count;
@@ -98,8 +92,6 @@ struct igc_mac_info {
9892

9993
u8 forced_speed_duplex;
10094

101-
bool adaptive_ifs;
102-
bool has_fwsm;
10395
bool asf_firmware_present;
10496
bool arc_subsystem_valid;
10597

@@ -276,21 +268,9 @@ struct igc_hw_stats {
276268
u64 tsctc;
277269
u64 tsctfc;
278270
u64 iac;
279-
u64 icrxptc;
280-
u64 icrxatc;
281-
u64 ictxptc;
282-
u64 ictxatc;
283-
u64 ictxqec;
284-
u64 ictxqmtc;
285-
u64 icrxdmtc;
286-
u64 icrxoc;
287-
u64 cbtmpc;
288271
u64 htdpmc;
289-
u64 cbrdpc;
290-
u64 cbrmpc;
291272
u64 rpthc;
292273
u64 hgptc;
293-
u64 htcbdpc;
294274
u64 hgorc;
295275
u64 hgotc;
296276
u64 lenerrs;

drivers/net/ethernet/intel/igc/igc_mac.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -295,20 +295,12 @@ void igc_clear_hw_cntrs_base(struct igc_hw *hw)
295295
rd32(IGC_MGTPTC);
296296

297297
rd32(IGC_IAC);
298-
rd32(IGC_ICRXOC);
299-
300-
rd32(IGC_ICRXPTC);
301-
rd32(IGC_ICRXATC);
302-
rd32(IGC_ICTXPTC);
303-
rd32(IGC_ICTXATC);
304-
rd32(IGC_ICTXQEC);
305-
rd32(IGC_ICTXQMTC);
306-
rd32(IGC_ICRXDMTC);
307298

308299
rd32(IGC_RPTHC);
309300
rd32(IGC_TLPIC);
310301
rd32(IGC_RLPIC);
311302
rd32(IGC_HGPTC);
303+
rd32(IGC_RXDMTC);
312304
rd32(IGC_HGORCL);
313305
rd32(IGC_HGORCH);
314306
rd32(IGC_HGOTCL);
@@ -363,8 +355,8 @@ void igc_rar_set(struct igc_hw *hw, u8 *addr, u32 index)
363355
s32 igc_check_for_copper_link(struct igc_hw *hw)
364356
{
365357
struct igc_mac_info *mac = &hw->mac;
358+
bool link = false;
366359
s32 ret_val;
367-
bool link;
368360

369361
/* We only want to go out to the PHY registers to see if Auto-Neg
370362
* has completed and/or if our link status has changed. The

drivers/net/ethernet/intel/igc/igc_main.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3730,14 +3730,6 @@ void igc_update_stats(struct igc_adapter *adapter)
37303730
adapter->stats.tsctc += rd32(IGC_TSCTC);
37313731

37323732
adapter->stats.iac += rd32(IGC_IAC);
3733-
adapter->stats.icrxoc += rd32(IGC_ICRXOC);
3734-
adapter->stats.icrxptc += rd32(IGC_ICRXPTC);
3735-
adapter->stats.icrxatc += rd32(IGC_ICRXATC);
3736-
adapter->stats.ictxptc += rd32(IGC_ICTXPTC);
3737-
adapter->stats.ictxatc += rd32(IGC_ICTXATC);
3738-
adapter->stats.ictxqec += rd32(IGC_ICTXQEC);
3739-
adapter->stats.ictxqmtc += rd32(IGC_ICTXQMTC);
3740-
adapter->stats.icrxdmtc += rd32(IGC_ICRXDMTC);
37413733

37423734
/* Fill out the OS statistics structure */
37433735
net_stats->multicast = adapter->stats.mprc;

drivers/net/ethernet/intel/igc/igc_regs.h

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,6 @@
5858
#define IGC_IVAR_MISC 0x01740 /* IVAR for "other" causes - RW */
5959
#define IGC_GPIE 0x01514 /* General Purpose Intr Enable - RW */
6060

61-
/* Interrupt Cause */
62-
#define IGC_ICRXPTC 0x04104 /* Rx Packet Timer Expire Count */
63-
#define IGC_ICRXATC 0x04108 /* Rx Absolute Timer Expire Count */
64-
#define IGC_ICTXPTC 0x0410C /* Tx Packet Timer Expire Count */
65-
#define IGC_ICTXATC 0x04110 /* Tx Absolute Timer Expire Count */
66-
#define IGC_ICTXQEC 0x04118 /* Tx Queue Empty Count */
67-
#define IGC_ICTXQMTC 0x0411C /* Tx Queue Min Threshold Count */
68-
#define IGC_ICRXDMTC 0x04120 /* Rx Descriptor Min Threshold Count */
69-
#define IGC_ICRXOC 0x04124 /* Receiver Overrun Count */
70-
7161
/* MSI-X Table Register Descriptions */
7262
#define IGC_PBACL 0x05B68 /* MSIx PBA Clear - R/W 1 to clear */
7363

@@ -182,10 +172,6 @@
182172
#define IGC_BPTC 0x040F4 /* Broadcast Packets Tx Count - R/clr */
183173
#define IGC_TSCTC 0x040F8 /* TCP Segmentation Context Tx - R/clr */
184174
#define IGC_IAC 0x04100 /* Interrupt Assertion Count */
185-
#define IGC_ICTXPTC 0x0410C /* Interrupt Cause Tx Pkt Timer Expire Count */
186-
#define IGC_ICTXATC 0x04110 /* Interrupt Cause Tx Abs Timer Expire Count */
187-
#define IGC_ICTXQEC 0x04118 /* Interrupt Cause Tx Queue Empty Count */
188-
#define IGC_ICTXQMTC 0x0411C /* Interrupt Cause Tx Queue Min Thresh Count */
189175
#define IGC_RPTHC 0x04104 /* Rx Packets To Host */
190176
#define IGC_TLPIC 0x04148 /* EEE Tx LPI Count */
191177
#define IGC_RLPIC 0x0414C /* EEE Rx LPI Count */

0 commit comments

Comments
 (0)