Skip to content

Commit edaa34e

Browse files
committed
Merge branch 'genetlink-remove-linux-genetlink-h'
Jakub Kicinski says: ==================== genetlink: remove linux/genetlink.h There are two genetlink headers net/genetlink.h and linux/genetlink.h This is similar to netlink.h, but for netlink.h both contain good amount of code. For genetlink.h the linux/ version is leftover from before uAPI headers were split out, it has 10 lines of code. Move those 10 lines into other appropriate headers and delete linux/genetlink.h. I occasionally open the wrong header in the editor when coding, I guess I'm not the only one. v2: https://lore.kernel.org/all/[email protected]/ v1: https://lore.kernel.org/all/[email protected] ==================== Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 092ca10 + cd72096 commit edaa34e

File tree

11 files changed

+26
-27
lines changed

11 files changed

+26
-27
lines changed

drivers/net/wireguard/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
#include <linux/init.h>
1616
#include <linux/module.h>
17-
#include <linux/genetlink.h>
17+
#include <net/genetlink.h>
1818
#include <net/rtnetlink.h>
1919

2020
static int __init wg_mod_init(void)

include/linux/genetlink.h

Lines changed: 0 additions & 19 deletions
This file was deleted.

include/linux/genl_magic_struct.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
#endif
1616

1717
#include <linux/args.h>
18-
#include <linux/genetlink.h>
1918
#include <linux/types.h>
19+
#include <net/genetlink.h>
2020

2121
extern int CONCATENATE(GENL_MAGIC_FAMILY, _genl_register)(void);
2222
extern void CONCATENATE(GENL_MAGIC_FAMILY, _genl_unregister)(void);

include/net/genetlink.h

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,20 @@
22
#ifndef __NET_GENERIC_NETLINK_H
33
#define __NET_GENERIC_NETLINK_H
44

5-
#include <linux/genetlink.h>
5+
#include <linux/net.h>
66
#include <net/netlink.h>
77
#include <net/net_namespace.h>
8+
#include <uapi/linux/genetlink.h>
89

910
#define GENLMSG_DEFAULT_SIZE (NLMSG_DEFAULT_SIZE - GENL_HDRLEN)
1011

12+
/* Non-parallel generic netlink requests are serialized by a global lock. */
13+
void genl_lock(void);
14+
void genl_unlock(void);
15+
16+
#define MODULE_ALIAS_GENL_FAMILY(family) \
17+
MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-" family)
18+
1119
/* Binding to multicast group requires %CAP_NET_ADMIN */
1220
#define GENL_MCAST_CAP_NET_ADMIN BIT(0)
1321
/* Binding to multicast group requires %CAP_SYS_ADMIN */

net/batman-adv/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include <linux/crc32c.h>
1515
#include <linux/device.h>
1616
#include <linux/errno.h>
17-
#include <linux/genetlink.h>
1817
#include <linux/gfp.h>
1918
#include <linux/if_ether.h>
2019
#include <linux/if_vlan.h>
@@ -38,6 +37,7 @@
3837
#include <linux/string.h>
3938
#include <linux/workqueue.h>
4039
#include <net/dsfield.h>
40+
#include <net/genetlink.h>
4141
#include <net/rtnetlink.h>
4242
#include <uapi/linux/batadv_packet.h>
4343
#include <uapi/linux/batman_adv.h>

net/batman-adv/netlink.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <linux/cache.h>
1616
#include <linux/err.h>
1717
#include <linux/errno.h>
18-
#include <linux/genetlink.h>
1918
#include <linux/gfp.h>
2019
#include <linux/if_ether.h>
2120
#include <linux/if_vlan.h>

net/netlink/af_netlink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
#include <linux/rhashtable.h>
6060
#include <asm/cacheflush.h>
6161
#include <linux/hash.h>
62-
#include <linux/genetlink.h>
6362
#include <linux/net_namespace.h>
6463
#include <linux/nospec.h>
6564
#include <linux/btf_ids.h>
@@ -73,6 +72,7 @@
7372
#include <trace/events/netlink.h>
7473

7574
#include "af_netlink.h"
75+
#include "genetlink.h"
7676

7777
struct listeners {
7878
struct rcu_head rcu;

net/netlink/genetlink.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
#include <net/sock.h>
2323
#include <net/genetlink.h>
2424

25+
#include "genetlink.h"
26+
2527
static DEFINE_MUTEX(genl_mutex); /* serialization of message processing */
2628
static DECLARE_RWSEM(cb_lock);
2729

net/netlink/genetlink.h

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/* SPDX-License-Identifier: GPL-2.0 */
2+
#ifndef __NET_GENETLINK_H
3+
#define __NET_GENETLINK_H
4+
5+
#include <linux/wait.h>
6+
7+
/* for synchronisation between af_netlink and genetlink */
8+
extern atomic_t genl_sk_destructing_cnt;
9+
extern wait_queue_head_t genl_sk_destructing_waitq;
10+
11+
#endif /* __LINUX_GENERIC_NETLINK_H */

net/openvswitch/datapath.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <linux/delay.h>
1616
#include <linux/time.h>
1717
#include <linux/etherdevice.h>
18-
#include <linux/genetlink.h>
1918
#include <linux/kernel.h>
2019
#include <linux/kthread.h>
2120
#include <linux/mutex.h>

net/openvswitch/meter.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <linux/kernel.h>
1212
#include <linux/netlink.h>
1313
#include <linux/openvswitch.h>
14-
#include <linux/genetlink.h>
1514
#include <linux/skbuff.h>
1615
#include <linux/bits.h>
1716

0 commit comments

Comments
 (0)