Skip to content

Allow making reference to global variables. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2017
Merged

Allow making reference to global variables. #22

merged 2 commits into from
Jan 12, 2017

Conversation

CodaFi
Copy link
Member

@CodaFi CodaFi commented Jan 12, 2017

Not sure if this should be partial.

@harlanhaskins
Copy link
Member

Should this be in Module along with function(named:) and type(named:)?

@harlanhaskins
Copy link
Member

Or should we move those both to IRBuilder?

harlanhaskins
harlanhaskins reviewed Jan 12, 2017
View reviewed changes
Sources/LLVM/IRBuilder.swift
@@ -989,6 +989,19 @@ public class IRBuilder {
public func buildGlobalStringPtr(_ string: String, name: String = "") -> IRValue {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and roll a change to make this return a Global

@CodaFi
Copy link
Member Author

CodaFi commented Jan 12, 2017

⛵️

@CodaFi CodaFi merged commit 0c6b336 into llvm-swift:master Jan 12, 2017
@CodaFi CodaFi deleted the mister-worldwide branch January 12, 2017 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins harlanhaskins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @harlanhaskins