Add the majority of the remaining optimizer passes #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented passes require parameters that we cannot provide if we're going to keep the existing lookup mechanism. We need to be clever about argument saturation for parametrized optimizations.
|
I'd be up for not using this lookup mechanism then... |
|
It would be a shame to ditch it because of two pass families. I think there's a way to be clever about passing the arguments through and maintaining the existing lookup scheme. What that is, ¯_(ツ)_/¯. |
|
Is a switch statement that much worse than a static dict? Pretty sure Swift will compile this into a jump table based on the descriminating bits in the enum, so it shouldn't have a performance penalty |
|
Mhm. The alternative I was thinking of probably won't work. OK, a big-honking jump table it will be. |
harlanhaskins
requested changes
Jan 13, 2017
|
I'll revert this and leave the comments in so we can return to this. |
CodaFi
force-pushed
the
dont-pass-me-by
branch
from
b5e60e3 to
5eb9f65
Compare
|
As long as the root is GTG: ⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented passes require parameters that we cannot provide if we're
going to keep the existing lookup mechanism.