Add fence, cmpxchg and atomicRMW to the builder
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
force-pushed
the
finger-on-the-button
branch
from
6f82a5b to
e545ab0
Compare
|
With this patch the builder is quickly approaching 1500 LoC. It's gonna need to be broken up soon. |
CodaFi
force-pushed
the
finger-on-the-button
branch
from
e545ab0 to
edbc3bf
Compare
| /// `memory_order_seq_cst` and Java volatile. | ||
| case sequentiallyConsistent = 6 | ||
|
|
||
| static let orderingMapping: [AtomicOrdering: LLVMAtomicOrdering] = [ |
|
|
||
| /// `AtomicRMWOperation` enumerates the kinds of supported atomic | ||
| /// read-write-modify operations. | ||
| public enum AtomicRMWOperation { |
| singleThreaded: Bool = false | ||
| ) -> IRValue { | ||
|
|
||
| if failureOrdering.rawValue < AtomicOrdering.monotonic.rawValue { |
There was a problem hiding this comment.
Maybe just make a conformance to Comparable?
CodaFi
force-pushed
the
finger-on-the-button
branch
from
edbc3bf to
cb1346f
Compare
CodaFi
force-pushed
the
finger-on-the-button
branch
from
cb1346f to
88156c6
Compare
|
@harlanhaskins ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next instructions I'm going to focus on will be the
extract*family becauseatomic cmpxchgis pretty useless without it.