Add Alias emission to the builder #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM pending that comment |
|
Uh, which comment? |
|
I left a review comment, basically saying that the declaration of Alias needs a comment |
Aliases are completely useless at the moment as there aren’t wrappers for its accessors.
|
@harlanhaskins How does it look now? |
harlanhaskins
approved these changes
Jan 14, 2017
| @@ -0,0 +1,10 @@ | |||
| import cllvm | |||
|
|
|||
| public struct Alias: IRValue { | |||
There was a problem hiding this comment.
Doc comment here. Can probably just copy&paste the one from addAlias
|
Oh, there's your comment. Silly Github. ⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliases are nearly useless at the moment as there aren’t wrappers for its accessors.