Document Some Values #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
approved these changes
Jan 9, 2017
| @@ -67,17 +103,35 @@ public final class Module { | |||
| throw ModuleError.couldNotEmitBitCode(path: path) | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| /// Creates a type with the given name in this module if that name does not | |||
There was a problem hiding this comment.
This function doesn't create any new types, only retrieves.
| public func type(named name: String) -> IRType? { | ||
| guard let type = LLVMGetTypeByName(llvm, name) else { return nil } | ||
| return convertType(type) | ||
| } | ||
|
|
||
|
|
||
| /// Creates a function with the given name in this module if that name does |
There was a problem hiding this comment.
Same here, only retrieves named functions
harlanhaskins
requested changes
Jan 9, 2017
|
Re |
|
Or we make a |
CodaFi
force-pushed
the
doctored-evidence
branch
from
3d02cf3 to
8fdf2ce
Compare
harlanhaskins
approved these changes
Jan 9, 2017
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents
May want to consider refactoring
Use. It's a weird data type that should be aSequence.