Added iteration attributes to Module, Global, and Function #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
reviewed
Jan 14, 2017
| /// Dump a representation of this module to stderr. | ||
| public func dump() { | ||
| LLVMDumpModule(llvm) | ||
| } | ||
|
|
||
| /// The full text IR of this module | ||
| public var description: String { | ||
| let cStr = LLVMPrintModuleToString(llvm)! |
There was a problem hiding this comment.
This seems... heavy for description. But I can find precedent in other bindings for this.
There was a problem hiding this comment.
I can't think of any other thing for description.
This would also allow for print(module) to print the IR.
|
LGTM modulo the discussion I just started. |
CodaFi
approved these changes
Jan 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.