Try explicit version number first #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
requested changes
Jan 22, 2017
| @@ -58,7 +58,7 @@ func makeFile() throws { | |||
| let cllvmPath = pkgConfigDir.appendingPathComponent("cllvm.pc") | |||
|
|
|||
| /// Ensure we have llvm-config in the PATH | |||
| guard let llvmConfig = which("llvm-config") else { | |||
| guard let llvmConfig = which("llvm-config-3.9") ?? which("llvm-config") else { | |||
There was a problem hiding this comment.
I got the opposite impression from this comment, so I'm just double checking...
There was a problem hiding this comment.
Oh, well. I trust Harlan's judgement here.
CodaFi
approved these changes
Jan 22, 2017
|
Thank you kindly for the contribution (and for putting up with me through review). ⛵️ |
|
Actually, Keep it that way. LLVM-config-3.9 is more likely to be right
…Sent from my Apple Watch
On Jan 21, 2017, at 8:03 PM, Kofi ***@***.***> wrote:
@hkgumbs commented on this pull request.
In utils/make-pkgconfig.swift:
> @@ -58,7 +58,7 @@ func makeFile() throws {
let cllvmPath = pkgConfigDir.appendingPathComponent("cllvm.pc")
/// Ensure we have llvm-config in the PATH
- guard let llvmConfig = which("llvm-config") else {
+ guard let llvmConfig = which("llvm-config-3.9") ?? which("llvm-config") else {
I got the opposite impression from this comment, so I'm just double checking
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks @hkgumbs! Alright, to clarify. On some systems, the default LLVM installation installs to Were we to use So this is correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That didn't take long at all. Were y'all thinking of something more complex?
Iteration on #47