Added spelled-out aliases for abbreviated predicate cases. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
requested changes
Feb 13, 2017
| static let orderedLessThanOrEqual = ole | ||
| /// Ordered and not equal. | ||
| static let orderedNotEqual = one | ||
| /// Oredered (no nans). |
There was a problem hiding this comment.
Can you fix this and the corresponding one in RealPredicate?
|
I've been waffling back and forth, but I agree with you. Should we bother with deprecation warnings or just rip the band-aid off and make an @channel on the Slack? |
|
I think a single point-release containing a set of migration aliases will be fine. I doubt anybody is using |
CodaFi
reviewed
Feb 13, 2017
Sources/LLVM/IRBuilder.swift
Outdated
| /// Ordered and not equal. | ||
| case one | ||
| case orderedNotEqual | ||
| /// Oredered (no nans). |
There was a problem hiding this comment.
Documentation flub still exists.
CodaFi
approved these changes
Feb 13, 2017
|
Will merge once CI passes |
|
🚢 🇮🇹 |
harlanhaskins
added a commit
that referenced
this pull request
Feb 19, 2017
* Added spelled-out aliases for abbreviated predicate cases. * Added deprecations with fixits for renaming to the expanded cases. * Updated tests to fix deprecation warnings. * Fixed documentation flub. * Fixed documentation flub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.