Lift some lli verification checks #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
requested changes
May 19, 2017
Sources/LLVM/PointerType.swift
Outdated
| @@ -24,6 +24,12 @@ public struct PointerType: IRType { | |||
| /// - parameter addressSpace: The optional address space where the pointed-to | |||
| /// object resides. | |||
| public init(pointee: IRType, addressSpace: Int = 0) { | |||
| // FIXME: This class of invalid reference is not caught by Module.verify(), | |||
| // only `lli`. | |||
| if LLVMGetTypeKind(pointee.asLLVM()) == LLVMVoidTypeKind { | |||
There was a problem hiding this comment.
pointee is VoidType, no? LLVMTypeRef doesn't conform to IRType and it's guaranteed that an IRType with kind LLVMVoidTypeKind is going to be VoidType
CodaFi
force-pushed
the
low-level-verified-module
branch
from
7d7fea1 to
9320fd9
Compare
CodaFi
changed the title
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some temporary fixes for lli being stricter than the LLVM verifier.