Skip to content

Commit 05a948e

Browse files
rovkarovka
committed
[flang] Rename variables in test. NFCI
Use pertinent names instead of numbered values, to make it easier to update the test in future patches. Differential Revision: https://reviews.llvm.org/D130474
1 parent b43bec1 commit 05a948e

File tree

1 file changed

+31
-31
lines changed

1 file changed

+31
-31
lines changed

‎flang/test/Lower/Intrinsics/get_command_argument-optional.f90

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2,42 +2,42 @@
22
! RUN: bbc -emit-fir %s -o - | FileCheck %s
33

44
! CHECK-LABEL: func @_QPtest(
5-
! CHECK-SAME: %[[VAL_0:.*]]: !fir.ref<i32> {fir.bindc_name = "number", fir.optional},
6-
! CHECK-SAME: %[[VAL_1:.*]]: !fir.boxchar<1> {fir.bindc_name = "value", fir.optional},
7-
! CHECK-SAME: %[[VAL_2:.*]]: !fir.ref<i32> {fir.bindc_name = "length", fir.optional},
8-
! CHECK-SAME: %[[VAL_3:.*]]: !fir.ref<i32> {fir.bindc_name = "status", fir.optional},
9-
! CHECK-SAME: %[[VAL_4:.*]]: !fir.boxchar<1> {fir.bindc_name = "errmsg", fir.optional}) {
5+
! CHECK-SAME: %[[numberParam:.*]]: !fir.ref<i32> {fir.bindc_name = "number", fir.optional},
6+
! CHECK-SAME: %[[valueParam:.*]]: !fir.boxchar<1> {fir.bindc_name = "value", fir.optional},
7+
! CHECK-SAME: %[[lengthParam:.*]]: !fir.ref<i32> {fir.bindc_name = "length", fir.optional},
8+
! CHECK-SAME: %[[statusParam:.*]]: !fir.ref<i32> {fir.bindc_name = "status", fir.optional},
9+
! CHECK-SAME: %[[errmsgParam:.*]]: !fir.boxchar<1> {fir.bindc_name = "errmsg", fir.optional}) {
1010
subroutine test(number, value, length, status, errmsg)
1111
integer, optional :: number, status, length
1212
character(*), optional :: value, errmsg
1313
! Note: number cannot be absent
1414
call get_command_argument(number, value, length, status, errmsg)
15-
! CHECK: %[[VAL_5:.*]]:2 = fir.unboxchar %[[VAL_4]] : (!fir.boxchar<1>) -> (!fir.ref<!fir.char<1,?>>, index)
16-
! CHECK: %[[VAL_6:.*]]:2 = fir.unboxchar %[[VAL_1]] : (!fir.boxchar<1>) -> (!fir.ref<!fir.char<1,?>>, index)
17-
! CHECK: %[[VAL_7:.*]] = fir.load %[[VAL_0]] : !fir.ref<i32>
18-
! CHECK: %[[VAL_8:.*]] = fir.is_present %[[VAL_6]]#0 : (!fir.ref<!fir.char<1,?>>) -> i1
19-
! CHECK: %[[VAL_9:.*]] = fir.embox %[[VAL_6]]#0 typeparams %[[VAL_6]]#1 : (!fir.ref<!fir.char<1,?>>, index) -> !fir.box<!fir.char<1,?>>
20-
! CHECK: %[[VAL_10:.*]] = fir.absent !fir.box<!fir.char<1,?>>
21-
! CHECK: %[[VAL_11:.*]] = arith.select %[[VAL_8]], %[[VAL_9]], %[[VAL_10]] : !fir.box<!fir.char<1,?>>
22-
! CHECK: %[[VAL_12:.*]] = fir.is_present %[[VAL_5]]#0 : (!fir.ref<!fir.char<1,?>>) -> i1
23-
! CHECK: %[[VAL_13:.*]] = fir.embox %[[VAL_5]]#0 typeparams %[[VAL_5]]#1 : (!fir.ref<!fir.char<1,?>>, index) -> !fir.box<!fir.char<1,?>>
24-
! CHECK: %[[VAL_14:.*]] = fir.absent !fir.box<!fir.char<1,?>>
25-
! CHECK: %[[VAL_15:.*]] = arith.select %[[VAL_12]], %[[VAL_13]], %[[VAL_14]] : !fir.box<!fir.char<1,?>>
26-
! CHECK: %[[VAL_16:.*]] = fir.convert %[[VAL_11]] : (!fir.box<!fir.char<1,?>>) -> !fir.box<none>
27-
! CHECK: %[[VAL_17:.*]] = fir.convert %[[VAL_15]] : (!fir.box<!fir.char<1,?>>) -> !fir.box<none>
28-
! CHECK: %[[VAL_18:.*]] = fir.call @_FortranAArgumentValue(%[[VAL_7]], %[[VAL_16]], %[[VAL_17]]) : (i32, !fir.box<none>, !fir.box<none>) -> i32
29-
! CHECK: %[[VAL_19:.*]] = fir.convert %[[VAL_3]] : (!fir.ref<i32>) -> i64
30-
! CHECK: %[[VAL_20:.*]] = arith.constant 0 : i64
31-
! CHECK: %[[VAL_21:.*]] = arith.cmpi ne, %[[VAL_19]], %[[VAL_20]] : i64
32-
! CHECK: fir.if %[[VAL_21]] {
33-
! CHECK: fir.store %[[VAL_18]] to %[[VAL_3]] : !fir.ref<i32>
15+
! CHECK: %[[errmsgUnboxed:.*]]:2 = fir.unboxchar %[[errmsgParam]] : (!fir.boxchar<1>) -> (!fir.ref<!fir.char<1,?>>, index)
16+
! CHECK: %[[valueUnboxed:.*]]:2 = fir.unboxchar %[[valueParam]] : (!fir.boxchar<1>) -> (!fir.ref<!fir.char<1,?>>, index)
17+
! CHECK: %[[number:.*]] = fir.load %[[numberParam]] : !fir.ref<i32>
18+
! CHECK: %[[valueIsPresent:.*]] = fir.is_present %[[valueUnboxed]]#0 : (!fir.ref<!fir.char<1,?>>) -> i1
19+
! CHECK: %[[valueReboxed:.*]] = fir.embox %[[valueUnboxed]]#0 typeparams %[[valueUnboxed]]#1 : (!fir.ref<!fir.char<1,?>>, index) -> !fir.box<!fir.char<1,?>>
20+
! CHECK: %[[valueAbsent:.*]] = fir.absent !fir.box<!fir.char<1,?>>
21+
! CHECK: %[[valueOrAbsent:.*]] = arith.select %[[valueIsPresent]], %[[valueReboxed]], %[[valueAbsent]] : !fir.box<!fir.char<1,?>>
22+
! CHECK: %[[errmsgIsPresent:.*]] = fir.is_present %[[errmsgUnboxed]]#0 : (!fir.ref<!fir.char<1,?>>) -> i1
23+
! CHECK: %[[errmsgReboxed:.*]] = fir.embox %[[errmsgUnboxed]]#0 typeparams %[[errmsgUnboxed]]#1 : (!fir.ref<!fir.char<1,?>>, index) -> !fir.box<!fir.char<1,?>>
24+
! CHECK: %[[errmsgAbsent:.*]] = fir.absent !fir.box<!fir.char<1,?>>
25+
! CHECK: %[[errmsgOrAbsent:.*]] = arith.select %[[errmsgIsPresent]], %[[errmsgReboxed]], %[[errmsgAbsent]] : !fir.box<!fir.char<1,?>>
26+
! CHECK: %[[value:.*]] = fir.convert %[[valueOrAbsent]] : (!fir.box<!fir.char<1,?>>) -> !fir.box<none>
27+
! CHECK: %[[errmsg:.*]] = fir.convert %[[errmsgOrAbsent]] : (!fir.box<!fir.char<1,?>>) -> !fir.box<none>
28+
! CHECK: %[[status:.*]] = fir.call @_FortranAArgumentValue(%[[number]], %[[value]], %[[errmsg]]) : (i32, !fir.box<none>, !fir.box<none>) -> i32
29+
! CHECK: %[[statusI64:.*]] = fir.convert %[[statusParam]] : (!fir.ref<i32>) -> i64
30+
! CHECK: %[[zero:.*]] = arith.constant 0 : i64
31+
! CHECK: %[[statusIsNonNull:.*]] = arith.cmpi ne, %[[statusI64]], %[[zero]] : i64
32+
! CHECK: fir.if %[[statusIsNonNull]] {
33+
! CHECK: fir.store %[[status]] to %[[statusParam]] : !fir.ref<i32>
3434
! CHECK: }
35-
! CHECK: %[[VAL_22:.*]] = fir.convert %[[VAL_2]] : (!fir.ref<i32>) -> i64
36-
! CHECK: %[[VAL_23:.*]] = arith.constant 0 : i64
37-
! CHECK: %[[VAL_24:.*]] = arith.cmpi ne, %[[VAL_22]], %[[VAL_23]] : i64
38-
! CHECK: fir.if %[[VAL_24]] {
39-
! CHECK: %[[VAL_25:.*]] = fir.call @_FortranAArgumentLength(%[[VAL_7]]) : (i32) -> i64
40-
! CHECK: %[[VAL_26:.*]] = fir.convert %[[VAL_25]] : (i64) -> i32
41-
! CHECK: fir.store %[[VAL_26]] to %[[VAL_2]] : !fir.ref<i32>
35+
! CHECK: %[[lengthI64:.*]] = fir.convert %[[lengthParam]] : (!fir.ref<i32>) -> i64
36+
! CHECK: %[[zero2:.*]] = arith.constant 0 : i64
37+
! CHECK: %[[lengthIsNonNull:.*]] = arith.cmpi ne, %[[lengthI64]], %[[zero2]] : i64
38+
! CHECK: fir.if %[[lengthIsNonNull]] {
39+
! CHECK: %[[length:.*]] = fir.call @_FortranAArgumentLength(%[[number]]) : (i32) -> i64
40+
! CHECK: %[[lengthTrunc:.*]] = fir.convert %[[length]] : (i64) -> i32
41+
! CHECK: fir.store %[[lengthTrunc]] to %[[lengthParam]] : !fir.ref<i32>
4242
! CHECK: }
4343
end subroutine

0 commit comments

Comments
 (0)