Skip to content

Commit 12f37b6

Browse files
committed
request_read_memory -> request_readMemory
1 parent 3b7e326 commit 12f37b6

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ def request_disassemble(
691691
for inst in instructions:
692692
self.disassembled_instructions[inst["address"]] = inst
693693

694-
def request_read_memory(self, memoryReference, offset, count):
694+
def request_readMemory(self, memoryReference, offset, count):
695695
args_dict = {
696696
"memoryReference": memoryReference,
697697
"offset": offset,

lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212

1313

1414
class TestDAP_memory(lldbdap_testcase.DAPTestCaseBase):
15-
def test_read_memory(self):
15+
def test_readMemory(self):
1616
"""
17-
Tests the 'read_memory' request
17+
Tests the 'readMemory' request
1818
"""
1919
program = self.getBuildArtifact("a.out")
2020
self.build_and_launch(program)
@@ -30,26 +30,26 @@ def test_read_memory(self):
3030
rawptr_ref = locals["rawptr"]["memoryReference"]
3131

3232
# We can read the complete string
33-
mem = self.dap_server.request_read_memory(rawptr_ref, 0, 5)["body"]
33+
mem = self.dap_server.request_readMemory(rawptr_ref, 0, 5)["body"]
3434
self.assertEqual(mem["unreadableBytes"], 0)
3535
self.assertEqual(b64decode(mem["data"]), b"dead\0")
3636

3737
# Use an offset
38-
mem = self.dap_server.request_read_memory(rawptr_ref, 2, 3)["body"]
38+
mem = self.dap_server.request_readMemory(rawptr_ref, 2, 3)["body"]
3939
self.assertEqual(b64decode(mem["data"]), b"ad\0")
4040

4141
# Use a negative offset
42-
mem = self.dap_server.request_read_memory(rawptr_ref, -1, 6)["body"]
42+
mem = self.dap_server.request_readMemory(rawptr_ref, -1, 6)["body"]
4343
self.assertEqual(b64decode(mem["data"])[1:], b"dead\0")
4444

4545
# Reads of size 0 are successful
4646
# VS-Code sends those in order to check if a `memoryReference` can actually be dereferenced.
47-
mem = self.dap_server.request_read_memory(rawptr_ref, 0, 0)
47+
mem = self.dap_server.request_readMemory(rawptr_ref, 0, 0)
4848
self.assertEqual(mem["success"], True)
4949
self.assertEqual(mem["body"]["data"], "")
5050

5151
# Reads at offset 0x0 fail
52-
mem = self.dap_server.request_read_memory("0x0", 0, 6)
52+
mem = self.dap_server.request_readMemory("0x0", 0, 6)
5353
self.assertEqual(mem["success"], False)
5454
self.assertEqual(mem["message"], "Memory region is not readable")
5555

0 commit comments

Comments
 (0)