Skip to content

Commit 1e3af94

Browse files
authored
Disable fail-fast for libc++ builders. (#74485)
It seems the fail fast just doesn't strike the right balance. It wastes too many resources, especially if a build is killed because the machine it was running on got preempted. Instead, we should simply not run any future jobs if a failure has occured, while letting the already running jobs finish.
1 parent aaf3a8d commit 1e3af94

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/libcxx-build-and-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
runs-on: libcxx-runners-8-set
5454
continue-on-error: false
5555
strategy:
56-
fail-fast: true
56+
fail-fast: false
5757
matrix:
5858
config: [
5959
'generic-cxx03',
@@ -92,7 +92,7 @@ jobs:
9292
needs: [ stage1 ]
9393
continue-on-error: false
9494
strategy:
95-
fail-fast: true
95+
fail-fast: false
9696
matrix:
9797
config: [
9898
'generic-cxx11',

0 commit comments

Comments
 (0)