Disable fail-fast for libc++ builders. #74485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-github-workflow Author: Eric (EricWF) ChangesIt seems the fail fast just doesn't strike the right balance. Instead, we should simply not run any future jobs if a failure has Full diff: https://github.com/llvm/llvm-project/pull/74485.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 83786052a5391..68dafe0f34f45 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -92,7 +92,7 @@ jobs:
needs: [ stage1 ]
continue-on-error: false
strategy:
- fail-fast: true
+ fail-fast: false
matrix:
config: [
'generic-cxx11',
|
It seems the fail fast just doesn't strike the right balance. It wastes too many resources, especially if a build is killed because the machine it was running on got preempted. Instead, we should simply not run any future jobs if a failure has occured, while letting the already running jobs finish.
EricWF
force-pushed
the
disable-fail-fast
branch
from
20ae17c to
77cc25e
Compare
ldionne
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the fail fast just doesn't strike the right balance.
It wastes too many resources, especially if a build is killed because
the machine it was running on got preempted.
Instead, we should simply not run any future jobs if a failure has
occured, while letting the already running jobs finish.