Skip to content

Commit 1fc05b6

Browse files
committed
review comments:
- fix variable name to be uppercase - remove unneeded flags from SemaHLSL testcase
1 parent 906f105 commit 1fc05b6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

clang/lib/CodeGen/CGBuiltin.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18845,10 +18845,10 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
1884518845
false);
1884618846

1884718847
// Get overloaded name
18848-
std::string name =
18848+
std::string Name =
1884918849
Intrinsic::getName(CGM.getHLSLRuntime().getWaveReadLaneAtIntrinsic(),
1885018850
ArrayRef{OpExpr->getType()}, &CGM.getModule());
18851-
return EmitRuntimeCall(CGM.CreateRuntimeFunction(FT, name, {},
18851+
return EmitRuntimeCall(CGM.CreateRuntimeFunction(FT, Name, {},
1885218852
/*Local=*/false,
1885318853
/*AssumeConvergent=*/true),
1885418854
ArrayRef{OpExpr, OpIndex}, "hlsl.waveReadLaneAt");

clang/test/SemaHLSL/BuiltIns/WaveReadLaneAt-errors.hlsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify -verify-ignore-unexpected
1+
// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -emit-llvm-only -disable-llvm-passes -verify
22

33
bool test_too_few_arg() {
44
return __builtin_hlsl_wave_read_lane_at();

0 commit comments

Comments
 (0)