address review comments

Author: Thorsten Schütt

llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h

@@ -1181,19 +1181,7 @@ class MachineIRBuilder {
   /// \pre \p Res must be a generic virtual register with scalar type.
   ///
   /// \return a MachineInstrBuilder for the newly created instruction.
-  MachineInstrBuilder buildStepVector(const DstOp &Res,
-                                      const ConstantInt &Step);
-
-  /// Build and insert \p Res = G_STEP_VECTOR \p Step
-  ///
-  /// G_STEP_VECTOR returns a scalable vector of linear sequence of step \p Step
-  /// into \p Res.
-  ///
-  /// \pre setBasicBlock or setMI must have been called.
-  /// \pre \p Res must be a generic virtual register with scalar type.
-  ///
-  /// \return a MachineInstrBuilder for the newly created instruction.
-  MachineInstrBuilder buildStepVector(const DstOp &Res, const APInt &Step);
+  MachineInstrBuilder buildStepVector(const DstOp &Res, unsigned Step);
 
   /// Build and insert \p Res = G_VSCALE \p MinElts
   ///

llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp

@@ -810,17 +810,14 @@ MachineInstrBuilder MachineIRBuilder::buildInsert(const DstOp &Res,
 }
 
 MachineInstrBuilder MachineIRBuilder::buildStepVector(const DstOp &Res,
-                                                      const APInt &Step) {
-  ConstantInt *CI = ConstantInt::get(getMF().getFunction().getContext(), Step);
-  return buildStepVector(Res, *CI);
-}
+                                                      unsigned Step) {
+  ConstantInt *CI =
+      ConstantInt::get(getMF().getFunction().getContext(), APInt(64, Step));
 
-MachineInstrBuilder MachineIRBuilder::buildStepVector(const DstOp &Res,
-                                                      const ConstantInt &Step) {
   auto StepVector = buildInstr(TargetOpcode::G_STEP_VECTOR);
   StepVector->setDebugLoc(DebugLoc());
   Res.addDefToMIB(*getMRI(), StepVector);
-  StepVector.addCImm(&Step);
+  StepVector.addCImm(CI);
   return StepVector;
 }