Skip to content

Commit 3d646d1

Browse files
committed
fixup! fixup! fixup! fixup! [docs] Update docs on code-review process
Incorporate PR feedback
1 parent 3df98cd commit 3d646d1

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

llvm/docs/CodeReview.rst

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,12 +158,11 @@ approved. If unsure, the reviewer should provide a qualified approval, (e.g.,
158158
you are fairly certain that a particular community member will wish to review,
159159
even if that person hasn't done so yet.
160160

161-
If new comments are posted after the patch has been approved (but not yet
162-
merged), these need to be addressed following similar process as outlined
163-
above. Specifically, a reviewer should confirm that all feedback has been
164-
addressed before a patch is merged, including the newly posted comments.
165-
Exceptions apply - e.g. there's no need to confirm that a comment requesting a
166-
typo to be fixed has been addressed (this should be evident from the code).
161+
If additional feedback is provided after acceptance (by the same reviewer or
162+
another), the author should use their best judgement in deciding whether that
163+
feedback can be incorporated into the change without comment (say a typo) or
164+
requires further review discussion. More substantial comments (e.g. about the
165+
design) will usually require further discussion. If unsure, ask the reviewer.
167166

168167
Note that, if a reviewer has requested a particular community member to review,
169168
and after a week that community member has yet to respond, feel free to ping

0 commit comments

Comments
 (0)