Skip to content

Commit 3df98cd

Browse files
committed
fixup! fixup! fixup! [docs] Update docs on code-review process
Expand the new paragraph
1 parent d545001 commit 3df98cd

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

llvm/docs/CodeReview.rst

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,11 @@ you are fairly certain that a particular community member will wish to review,
159159
even if that person hasn't done so yet.
160160

161161
If new comments are posted after the patch has been approved (but not yet
162-
merged), these need to be addressed and all new changes have to be reviewed and
163-
approved by a reviewer.
162+
merged), these need to be addressed following similar process as outlined
163+
above. Specifically, a reviewer should confirm that all feedback has been
164+
addressed before a patch is merged, including the newly posted comments.
165+
Exceptions apply - e.g. there's no need to confirm that a comment requesting a
166+
typo to be fixed has been addressed (this should be evident from the code).
164167

165168
Note that, if a reviewer has requested a particular community member to review,
166169
and after a week that community member has yet to respond, feel free to ping

0 commit comments

Comments
 (0)