[CIR] Fix missing return value warning in maybePromoteBoolResult (#142673)

mmha · web-flow · commit 4d6e44db8726 · 2025-06-04T11:52:47.000+02:00
This is NFC and simply adds an llvm_unreachable
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -104,6 +104,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
       return builder.createBoolToInt(value, dstTy);
     if (mlir::isa<cir::BoolType>(dstTy))
       return value;
+    llvm_unreachable("Can only promote integer or boolean types");
   }
 
   //===--------------------------------------------------------------------===//

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {`
`104`	`104`	`return builder.createBoolToInt(value, dstTy);`
`105`	`105`	`if (mlir::isa<cir::BoolType>(dstTy))`
`106`	`106`	`return value;`
	`107`	`+ llvm_unreachable("Can only promote integer or boolean types");`
`107`	`108`	`}`
`108`	`109`
`109`	`110`	`//===--------------------------------------------------------------------===//`