[CIR] Fix missing return value warning in maybePromoteBoolResult #142673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is NFC and simply adds an llvm_unreachable
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Morris Hafner (mmha) ChangesThis is NFC and simply adds an llvm_unreachable Full diff: https://github.com/llvm/llvm-project/pull/142673.diff 1 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
index 77287ec45972d..0d9252a55d280 100644
--- a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -104,6 +104,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
return builder.createBoolToInt(value, dstTy);
if (mlir::isa<cir::BoolType>(dstTy))
return value;
+ llvm_unreachable("Can only promote integer or boolean types");
}
//===--------------------------------------------------------------------===//
|
|
@llvm/pr-subscribers-clangir Author: Morris Hafner (mmha) ChangesThis is NFC and simply adds an llvm_unreachable Full diff: https://github.com/llvm/llvm-project/pull/142673.diff 1 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
index 77287ec45972d..0d9252a55d280 100644
--- a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -104,6 +104,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
return builder.createBoolToInt(value, dstTy);
if (mlir::isa<cir::BoolType>(dstTy))
return value;
+ llvm_unreachable("Can only promote integer or boolean types");
}
//===--------------------------------------------------------------------===//
|
andykaylor
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
@AmrDeveloper posted a different fix for this here: #142591
I kind of like the change here better because it won't silently return an arbitrary value in release builds, and this really should be unreachable.
rorth
pushed a commit
to rorth/llvm-project
that referenced
this pull request
Jun 11, 2025
…m#142673) This is NFC and simply adds an llvm_unreachable
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
…m#142673) This is NFC and simply adds an llvm_unreachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is NFC and simply adds an llvm_unreachable