[libc] Add invalid tests and use ErrnoCheckingTest

Author: tszhin-swe

libc/include/sys/time.yaml

@@ -6,6 +6,7 @@ types:
   - type_name: struct_timeval
   - type_name: struct_itimerval
 enums: []
+objects: []
 functions:
   - name: utimes
     return_type: int
@@ -29,4 +30,3 @@ functions:
     arguments:
       - type: int
       - type: struct itimerval *
-objects: []

libc/src/sys/time/linux/CMakeLists.txt

@@ -12,6 +12,7 @@ add_entrypoint_object(
     libc.include.sys_syscall
     libc.include.fcntl
     libc.src.__support.OSUtil.osutil
+    libc.src.errno.errno
 )
 
 add_entrypoint_object(

libc/test/src/sys/time/CMakeLists.txt

@@ -27,11 +27,14 @@ add_libc_unittest(
   SRCS
     setitimer_test.cpp
   DEPENDS
+    libc.include.signal
     libc.src.sys.time.setitimer
+    libc.src.signal.sigaction
+    libc.src.signal.sigemptyset
     libc.src.__support.common
     libc.src.errno.errno
+    libc.test.UnitTest.ErrnoCheckingTest
     libc.test.UnitTest.ErrnoSetterMatcher
-    libc.include.signal
 )
 
 add_libc_unittest(
@@ -44,5 +47,6 @@ add_libc_unittest(
     libc.src.sys.time.getitimer
     libc.src.__support.common
     libc.src.errno.errno
+    libc.test.UnitTest.ErrnoCheckingTest
     libc.test.UnitTest.ErrnoSetterMatcher
 )

libc/test/src/sys/time/getitimer_test.cpp

@@ -9,13 +9,14 @@
 
 #include "hdr/types/struct_itimerval.h"
 #include "src/sys/time/getitimer.h"
+#include "test/UnitTest/ErrnoCheckingTest.h"
 #include "test/UnitTest/ErrnoSetterMatcher.h"
 #include "test/UnitTest/Test.h"
-#include <sys/time.h>
 
 using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher;
+using LlvmLibcSysTimeGetitimerTest = LIBC_NAMESPACE::testing::ErrnoCheckingTest;
 
-TEST(LlvmLibcSysTimeGetitimerTest, SmokeTest) {
+TEST_F(LlvmLibcSysTimeGetitimerTest, SmokeTest) {
   struct itimerval timer;
   timer.it_value.tv_sec = -1;
   timer.it_value.tv_usec = -1;
@@ -30,3 +31,11 @@ TEST(LlvmLibcSysTimeGetitimerTest, SmokeTest) {
   ASSERT_TRUE(timer.it_interval.tv_sec == 0);
   ASSERT_TRUE(timer.it_interval.tv_usec == 0);
 }
+
+TEST_F(LlvmLibcSysTimeGetitimerTest, InvalidRetTest) {
+  struct itimerval timer;
+
+  // out of range timer type (which)
+  ASSERT_THAT(LIBC_NAMESPACE::getitimer(99, &timer),
+              returns(NE(0)).with_errno(NE(0)));
+}

libc/test/src/sys/time/setitimer_test.cpp

@@ -8,19 +8,21 @@
 //===----------------------------------------------------------------------===//
 
 #include "hdr/types/struct_itimerval.h"
+#include "hdr/types/struct_sigaction.h"
+#include "src/signal/sigemptyset.h"
 #include "src/sys/time/setitimer.h"
+#include "test/UnitTest/ErrnoCheckingTest.h"
 #include "test/UnitTest/ErrnoSetterMatcher.h"
 #include "test/UnitTest/Test.h"
 
-#include <signal.h>
-
 using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher;
+using LlvmLibcSysTimeSetitimerTest = LIBC_NAMESPACE::testing::ErrnoCheckingTest;
 
 static bool timer_fired(false);
 
 extern "C" void handle_sigalrm(int) { timer_fired = true; }
 
-TEST(LlvmLibcSysTimeSetitimerTest, SmokeTest) {
+TEST_F(LlvmLibcSysTimeSetitimerTest, SmokeTest) {
   LIBC_NAMESPACE::libc_errno = 0;
   struct sigaction sa;
   sa.sa_handler = handle_sigalrm;
@@ -44,3 +46,11 @@ TEST(LlvmLibcSysTimeSetitimerTest, SmokeTest) {
 
   ASSERT_TRUE(timer_fired);
 }
+
+TEST_F(LlvmLibcSysTimeSetitimerTest, InvalidRetTest) {
+  struct itimerval timer;
+
+  // out of range timer type (which)
+  ASSERT_THAT(LIBC_NAMESPACE::setitimer(99, &timer, nullptr),
+              returns(NE(0)).with_errno(NE(0)));
+}