Skip to content

Commit 57b6171

Browse files
author
Kai Luo
committed
Add FIXME
1 parent 8e3f7f6 commit 57b6171

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -657,6 +657,12 @@ bool PPCRegisterInfo::getRegAllocationHints(Register VirtReg,
657657
if (!MO.isReg() || !MO.getReg() || !MO.getReg().isVirtual() ||
658658
!MO.isDef() || !VRM->hasPhys(MO.getReg()))
659659
continue;
660+
// FIXME: If PhysReg interferes with VirtReg, we should avoid using
661+
// PhysReg as hint to avoid potential split. Current
662+
// getRegAllocationHints doesn't interface LiveInterval, so the
663+
// interference check is not viable. In the other side, CRs don't live
664+
// cross multiple BBs in common cases, so checking interference might
665+
// help rare seen cases.
660666
MCPhysReg PhysReg = VRM->getPhys(MO.getReg());
661667
llvm::copy_if(
662668
TRI->superregs_inclusive(PhysReg),

0 commit comments

Comments
 (0)