[DAG] getValidShiftAmountRange - fix upper bound of ConstantRange

RKSimon · RKSimon · commit 5af5cd100571 · 2024-06-01T16:12:22.000+01:00
I forgot to account for ConstantRange expecting the upper bound to be non-inclusive
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -3045,7 +3045,7 @@ SelectionDAG::getValidShiftAmountRange(SDValue V, const APInt &DemandedElts,
     assert(((!MinAmt && !MaxAmt) || (MinAmt && MaxAmt)) &&
            "Failed to find matching min/max shift amounts");
     if (MinAmt && MaxAmt)
-      return ConstantRange(*MinAmt, *MaxAmt);
+      return ConstantRange(*MinAmt, *MaxAmt + 1);
   }
 
   // Use computeKnownBits to find a hidden constant/knownbits (usually type

Original file line number	Diff line number	Diff line change
`@@ -3045,7 +3045,7 @@ SelectionDAG::getValidShiftAmountRange(SDValue V, const APInt &DemandedElts,`
`3045`	`3045`	`assert(((!MinAmt && !MaxAmt) \|\| (MinAmt && MaxAmt)) &&`
`3046`	`3046`	`"Failed to find matching min/max shift amounts");`
`3047`	`3047`	`if (MinAmt && MaxAmt)`
`3048`		`- return ConstantRange(MinAmt, MaxAmt);`
	`3048`	`+ return ConstantRange(MinAmt, MaxAmt + 1);`
`3049`	`3049`	`}`
`3050`	`3050`
`3051`	`3051`	`// Use computeKnownBits to find a hidden constant/knownbits (usually type`