address comments

Author: Peiming Liu

mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td

@@ -484,7 +484,7 @@ def SparseSpaceCollapse : Pass<"sparse-space-collapse", "func::FuncOp"> {
   let summary = "sparse space collapsing pass";
   let description = [{
      This pass collapses consecutive sparse spaces (extracted from the same tensor)
-     into one multi-dimensional space. The pass is not yet stablized.
+     into one multi-dimensional space. The pass is not yet stabilized.
   }];
   let constructor = "mlir::createSparseSpaceCollapsePass()";
   let dependentDialects = [
@@ -496,7 +496,7 @@ def LowerSparseIterationToSCF : Pass<"lower-sparse-iteration-to-scf", "func::Fun
   let summary = "lower sparse_tensor.iterate/coiterate into scf loops";
   let description = [{
      This pass lowers `sparse_tensor.iterate` operations into `scf.for/while` operations.
-     The pass is not yet stablized.
+     The pass is not yet stabilized.
   }];
   let constructor = "mlir::createLowerSparseIterationToSCFPass()";
   let dependentDialects = [

mlir/lib/Dialect/SparseTensor/Transforms/SparseIterationToScf.cpp

@@ -17,7 +17,7 @@ void convertLevelType(SparseTensorEncodingAttr enc, Level lvl,
     fields.push_back(enc.getPosMemRefType());
   if (enc.getLvlType(lvl).isWithCrdLT())
     fields.push_back(enc.getCrdMemRefType());
-  // One index for shape bound (result from lvlOp)
+  // One index for shape bound (result from lvlOp).
   fields.push_back(IndexType::get(enc.getContext()));
 }
 

mlir/test/Dialect/SparseTensor/sparse_space_collapse.mlir

@@ -22,12 +22,10 @@ func.func @sparse_sparse_collapse(%sp : tensor<4x8xf32, #COO>) -> index {
   %i = arith.constant 0 : index
   %c1 = arith.constant 1 : index
   %l1 = sparse_tensor.extract_iteration_space %sp lvls = 0
-      : tensor<4x8xf32, #COO>
-     -> !sparse_tensor.iter_space<#COO, lvls = 0>
-    %r1 = sparse_tensor.iterate %it1 in %l1 iter_args(%outer = %i): !sparse_tensor.iter_space<#COO, lvls = 0 to 1> -> index {
+      : tensor<4x8xf32, #COO> -> !sparse_tensor.iter_space<#COO, lvls = 0>
+  %r1 = sparse_tensor.iterate %it1 in %l1 iter_args(%outer = %i): !sparse_tensor.iter_space<#COO, lvls = 0 to 1> -> index {
     %l2 = sparse_tensor.extract_iteration_space %sp at %it1 lvls = 1
-        : tensor<4x8xf32, #COO>, !sparse_tensor.iterator<#COO, lvls = 0 to 1>
-       -> !sparse_tensor.iter_space<#COO, lvls = 1>
+        : tensor<4x8xf32, #COO>, !sparse_tensor.iterator<#COO, lvls = 0 to 1> -> !sparse_tensor.iter_space<#COO, lvls = 1>
     %r2 = sparse_tensor.iterate %it2 in %l2 iter_args(%inner = %outer): !sparse_tensor.iter_space<#COO, lvls = 1 to 2> -> index {
       %k = arith.addi %inner, %c1 : index
       sparse_tensor.yield %k : index