Skip to content

Commit 68d45f8

Browse files
authored
Revert "[AMDGPU] Add AMDGPU specific variadic operation MCExprs (#82022)"
This reverts commit bec2d10.
1 parent 51e2354 commit 68d45f8

File tree

7 files changed

+0
-426
lines changed

7 files changed

+0
-426
lines changed

llvm/docs/AMDGPUUsage.rst

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,25 +1534,6 @@ The AMDGPU backend supports the following calling conventions:
15341534

15351535
=============================== ==========================================================
15361536

1537-
AMDGPU MCExpr
1538-
-------------
1539-
1540-
As part of the AMDGPU MC layer, AMDGPU provides the following target specific
1541-
``MCExpr``\s.
1542-
1543-
.. table:: AMDGPU MCExpr types:
1544-
:name: amdgpu-mcexpr-table
1545-
1546-
=================== ================= ========================================================
1547-
MCExpr Operands Return value
1548-
=================== ================= ========================================================
1549-
``max(arg, ...)`` 1 or more Variadic signed operation that returns the maximum
1550-
value of all its arguments.
1551-
1552-
``or(arg, ...)`` 1 or more Variadic signed operation that returns the bitwise-or
1553-
result of all its arguments.
1554-
1555-
=================== ================= ========================================================
15561537

15571538
.. _amdgpu-elf-code-object:
15581539

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
//===----------------------------------------------------------------------===//
88

99
#include "AMDKernelCodeT.h"
10-
#include "MCTargetDesc/AMDGPUMCExpr.h"
1110
#include "MCTargetDesc/AMDGPUMCTargetDesc.h"
1211
#include "MCTargetDesc/AMDGPUTargetStreamer.h"
1312
#include "SIDefines.h"
@@ -1817,7 +1816,6 @@ class AMDGPUAsmParser : public MCTargetAsmParser {
18171816

18181817
public:
18191818
void onBeginOfFile() override;
1820-
bool parsePrimaryExpr(const MCExpr *&Res, SMLoc &EndLoc) override;
18211819

18221820
ParseStatus parseCustomOperand(OperandVector &Operands, unsigned MCK);
18231821

@@ -8279,59 +8277,6 @@ void AMDGPUAsmParser::onBeginOfFile() {
82798277
getTargetStreamer().EmitDirectiveAMDGCNTarget();
82808278
}
82818279

8282-
/// Parse AMDGPU specific expressions.
8283-
///
8284-
/// expr ::= or(expr, ...) |
8285-
/// max(expr, ...)
8286-
///
8287-
bool AMDGPUAsmParser::parsePrimaryExpr(const MCExpr *&Res, SMLoc &EndLoc) {
8288-
using AGVK = AMDGPUVariadicMCExpr::VariadicKind;
8289-
8290-
if (isToken(AsmToken::Identifier)) {
8291-
StringRef TokenId = getTokenStr();
8292-
AGVK VK = StringSwitch<AGVK>(TokenId)
8293-
.Case("max", AGVK::AGVK_Max)
8294-
.Case("or", AGVK::AGVK_Or)
8295-
.Default(AGVK::AGVK_None);
8296-
8297-
if (VK != AGVK::AGVK_None && peekToken().is(AsmToken::LParen)) {
8298-
SmallVector<const MCExpr *, 4> Exprs;
8299-
uint64_t CommaCount = 0;
8300-
lex(); // Eat 'max'/'or'
8301-
lex(); // Eat '('
8302-
while (true) {
8303-
if (trySkipToken(AsmToken::RParen)) {
8304-
if (Exprs.empty()) {
8305-
Error(getToken().getLoc(),
8306-
"empty " + Twine(TokenId) + " expression");
8307-
return true;
8308-
}
8309-
if (CommaCount + 1 != Exprs.size()) {
8310-
Error(getToken().getLoc(),
8311-
"mismatch of commas in " + Twine(TokenId) + " expression");
8312-
return true;
8313-
}
8314-
Res = AMDGPUVariadicMCExpr::create(VK, Exprs, getContext());
8315-
return false;
8316-
}
8317-
const MCExpr *Expr;
8318-
if (getParser().parseExpression(Expr, EndLoc))
8319-
return true;
8320-
Exprs.push_back(Expr);
8321-
bool LastTokenWasComma = trySkipToken(AsmToken::Comma);
8322-
if (LastTokenWasComma)
8323-
CommaCount++;
8324-
if (!LastTokenWasComma && !isToken(AsmToken::RParen)) {
8325-
Error(getToken().getLoc(),
8326-
"unexpected token in " + Twine(TokenId) + " expression");
8327-
return true;
8328-
}
8329-
}
8330-
}
8331-
}
8332-
return getParser().parsePrimaryExpr(Res, EndLoc, nullptr);
8333-
}
8334-
83358280
ParseStatus AMDGPUAsmParser::parseOModSI(OperandVector &Operands) {
83368281
StringRef Name = getTokenStr();
83378282
if (Name == "mul") {

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCExpr.cpp

Lines changed: 0 additions & 94 deletions
This file was deleted.

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCExpr.h

Lines changed: 0 additions & 74 deletions
This file was deleted.

llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ add_llvm_component_library(LLVMAMDGPUDesc
55
AMDGPUInstPrinter.cpp
66
AMDGPUMCAsmInfo.cpp
77
AMDGPUMCCodeEmitter.cpp
8-
AMDGPUMCExpr.cpp
98
AMDGPUMCTargetDesc.cpp
109
AMDGPUTargetStreamer.cpp
1110
R600InstPrinter.cpp

0 commit comments

Comments
 (0)