Skip to content

Commit 884b19a

Browse files
[clang-tools-extra] Use *Set::insert_range (NFC) (#133589)
1 parent 3ef3306 commit 884b19a

File tree

4 files changed

+7
-14
lines changed

4 files changed

+7
-14
lines changed

clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -333,13 +333,10 @@ SignalHandlerCheck::SignalHandlerCheck(StringRef Name,
333333
: ClangTidyCheck(Name, Context),
334334
AsyncSafeFunctionSet(Options.get("AsyncSafeFunctionSet",
335335
AsyncSafeFunctionSetKind::POSIX)) {
336-
if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal) {
337-
for (StringRef v : MinimalConformingFunctions)
338-
ConformingFunctions.insert(v);
339-
} else {
340-
for (StringRef v : POSIXConformingFunctions)
341-
ConformingFunctions.insert(v);
342-
}
336+
if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal)
337+
ConformingFunctions.insert_range(MinimalConformingFunctions);
338+
else
339+
ConformingFunctions.insert_range(POSIXConformingFunctions);
343340
}
344341

345342
void SignalHandlerCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {

clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -343,9 +343,7 @@ void InconsistentDeclarationParameterNameCheck::check(
343343

344344
void InconsistentDeclarationParameterNameCheck::markRedeclarationsAsVisited(
345345
const FunctionDecl *OriginalDeclaration) {
346-
for (const FunctionDecl *Redecl : OriginalDeclaration->redecls()) {
347-
VisitedDeclarations.insert(Redecl);
348-
}
346+
VisitedDeclarations.insert_range(OriginalDeclaration->redecls());
349347
}
350348

351349
} // namespace clang::tidy::readability

clang-tools-extra/clangd/ConfigCompile.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,8 +439,7 @@ struct FragmentCompiler {
439439
[Normalized(std::move(Normalized))](const Params &, Config &C) {
440440
if (C.Diagnostics.SuppressAll)
441441
return;
442-
for (llvm::StringRef N : Normalized)
443-
C.Diagnostics.Suppress.insert(N);
442+
C.Diagnostics.Suppress.insert_range(Normalized);
444443
});
445444

446445
if (F.UnusedIncludes) {

clang-tools-extra/clangd/index/dex/Dex.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,7 @@ std::unique_ptr<Iterator> Dex::createFileProximityIterator(
181181
Sources[Path] = SourceParams();
182182
auto PathURI = URI::create(Path).toString();
183183
const auto PathProximityURIs = generateProximityURIs(PathURI.c_str());
184-
for (const auto &ProximityURI : PathProximityURIs)
185-
ParentURIs.insert(ProximityURI);
184+
ParentURIs.insert_range(PathProximityURIs);
186185
}
187186
// Use SymbolRelevanceSignals for symbol relevance evaluation: use defaults
188187
// for all parameters except for Proximity Path distance signal.

0 commit comments

Comments
 (0)