[clang-tools-extra] Use *Set::insert_range (NFC) #133589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang-tidy Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/133589.diff 4 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
index 902490f4d33c1..27045816a80d3 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
@@ -333,13 +333,10 @@ SignalHandlerCheck::SignalHandlerCheck(StringRef Name,
: ClangTidyCheck(Name, Context),
AsyncSafeFunctionSet(Options.get("AsyncSafeFunctionSet",
AsyncSafeFunctionSetKind::POSIX)) {
- if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal) {
- for (StringRef v : MinimalConformingFunctions)
- ConformingFunctions.insert(v);
- } else {
- for (StringRef v : POSIXConformingFunctions)
- ConformingFunctions.insert(v);
- }
+ if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal)
+ ConformingFunctions.insert_range(MinimalConformingFunctions);
+ else
+ ConformingFunctions.insert_range(POSIXConformingFunctions);
}
void SignalHandlerCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
diff --git a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
index c41f81b0f0b58..a60a4faa32a16 100644
--- a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
@@ -343,9 +343,7 @@ void InconsistentDeclarationParameterNameCheck::check(
void InconsistentDeclarationParameterNameCheck::markRedeclarationsAsVisited(
const FunctionDecl *OriginalDeclaration) {
- for (const FunctionDecl *Redecl : OriginalDeclaration->redecls()) {
- VisitedDeclarations.insert(Redecl);
- }
+ VisitedDeclarations.insert_range(OriginalDeclaration->redecls());
}
} // namespace clang::tidy::readability
diff --git a/clang-tools-extra/clangd/ConfigCompile.cpp b/clang-tools-extra/clangd/ConfigCompile.cpp
index 21304a8c0fac7..3d7f792aa136b 100644
--- a/clang-tools-extra/clangd/ConfigCompile.cpp
+++ b/clang-tools-extra/clangd/ConfigCompile.cpp
@@ -439,8 +439,7 @@ struct FragmentCompiler {
[Normalized(std::move(Normalized))](const Params &, Config &C) {
if (C.Diagnostics.SuppressAll)
return;
- for (llvm::StringRef N : Normalized)
- C.Diagnostics.Suppress.insert(N);
+ C.Diagnostics.Suppress.insert_range(Normalized);
});
if (F.UnusedIncludes) {
diff --git a/clang-tools-extra/clangd/index/dex/Dex.cpp b/clang-tools-extra/clangd/index/dex/Dex.cpp
index 5643ba0c5e4ce..575a96a112979 100644
--- a/clang-tools-extra/clangd/index/dex/Dex.cpp
+++ b/clang-tools-extra/clangd/index/dex/Dex.cpp
@@ -181,8 +181,7 @@ std::unique_ptr<Iterator> Dex::createFileProximityIterator(
Sources[Path] = SourceParams();
auto PathURI = URI::create(Path).toString();
const auto PathProximityURIs = generateProximityURIs(PathURI.c_str());
- for (const auto &ProximityURI : PathProximityURIs)
- ParentURIs.insert(ProximityURI);
+ ParentURIs.insert_range(PathProximityURIs);
}
// Use SymbolRelevanceSignals for symbol relevance evaluation: use defaults
// for all parameters except for Proximity Path distance signal.
|
|
@llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/133589.diff 4 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
index 902490f4d33c1..27045816a80d3 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
@@ -333,13 +333,10 @@ SignalHandlerCheck::SignalHandlerCheck(StringRef Name,
: ClangTidyCheck(Name, Context),
AsyncSafeFunctionSet(Options.get("AsyncSafeFunctionSet",
AsyncSafeFunctionSetKind::POSIX)) {
- if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal) {
- for (StringRef v : MinimalConformingFunctions)
- ConformingFunctions.insert(v);
- } else {
- for (StringRef v : POSIXConformingFunctions)
- ConformingFunctions.insert(v);
- }
+ if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal)
+ ConformingFunctions.insert_range(MinimalConformingFunctions);
+ else
+ ConformingFunctions.insert_range(POSIXConformingFunctions);
}
void SignalHandlerCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
diff --git a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
index c41f81b0f0b58..a60a4faa32a16 100644
--- a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
@@ -343,9 +343,7 @@ void InconsistentDeclarationParameterNameCheck::check(
void InconsistentDeclarationParameterNameCheck::markRedeclarationsAsVisited(
const FunctionDecl *OriginalDeclaration) {
- for (const FunctionDecl *Redecl : OriginalDeclaration->redecls()) {
- VisitedDeclarations.insert(Redecl);
- }
+ VisitedDeclarations.insert_range(OriginalDeclaration->redecls());
}
} // namespace clang::tidy::readability
diff --git a/clang-tools-extra/clangd/ConfigCompile.cpp b/clang-tools-extra/clangd/ConfigCompile.cpp
index 21304a8c0fac7..3d7f792aa136b 100644
--- a/clang-tools-extra/clangd/ConfigCompile.cpp
+++ b/clang-tools-extra/clangd/ConfigCompile.cpp
@@ -439,8 +439,7 @@ struct FragmentCompiler {
[Normalized(std::move(Normalized))](const Params &, Config &C) {
if (C.Diagnostics.SuppressAll)
return;
- for (llvm::StringRef N : Normalized)
- C.Diagnostics.Suppress.insert(N);
+ C.Diagnostics.Suppress.insert_range(Normalized);
});
if (F.UnusedIncludes) {
diff --git a/clang-tools-extra/clangd/index/dex/Dex.cpp b/clang-tools-extra/clangd/index/dex/Dex.cpp
index 5643ba0c5e4ce..575a96a112979 100644
--- a/clang-tools-extra/clangd/index/dex/Dex.cpp
+++ b/clang-tools-extra/clangd/index/dex/Dex.cpp
@@ -181,8 +181,7 @@ std::unique_ptr<Iterator> Dex::createFileProximityIterator(
Sources[Path] = SourceParams();
auto PathURI = URI::create(Path).toString();
const auto PathProximityURIs = generateProximityURIs(PathURI.c_str());
- for (const auto &ProximityURI : PathProximityURIs)
- ParentURIs.insert(ProximityURI);
+ ParentURIs.insert_range(PathProximityURIs);
}
// Use SymbolRelevanceSignals for symbol relevance evaluation: use defaults
// for all parameters except for Proximity Path distance signal.
|
|
@llvm/pr-subscribers-clangd Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/133589.diff 4 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
index 902490f4d33c1..27045816a80d3 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp
@@ -333,13 +333,10 @@ SignalHandlerCheck::SignalHandlerCheck(StringRef Name,
: ClangTidyCheck(Name, Context),
AsyncSafeFunctionSet(Options.get("AsyncSafeFunctionSet",
AsyncSafeFunctionSetKind::POSIX)) {
- if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal) {
- for (StringRef v : MinimalConformingFunctions)
- ConformingFunctions.insert(v);
- } else {
- for (StringRef v : POSIXConformingFunctions)
- ConformingFunctions.insert(v);
- }
+ if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal)
+ ConformingFunctions.insert_range(MinimalConformingFunctions);
+ else
+ ConformingFunctions.insert_range(POSIXConformingFunctions);
}
void SignalHandlerCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
diff --git a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
index c41f81b0f0b58..a60a4faa32a16 100644
--- a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
@@ -343,9 +343,7 @@ void InconsistentDeclarationParameterNameCheck::check(
void InconsistentDeclarationParameterNameCheck::markRedeclarationsAsVisited(
const FunctionDecl *OriginalDeclaration) {
- for (const FunctionDecl *Redecl : OriginalDeclaration->redecls()) {
- VisitedDeclarations.insert(Redecl);
- }
+ VisitedDeclarations.insert_range(OriginalDeclaration->redecls());
}
} // namespace clang::tidy::readability
diff --git a/clang-tools-extra/clangd/ConfigCompile.cpp b/clang-tools-extra/clangd/ConfigCompile.cpp
index 21304a8c0fac7..3d7f792aa136b 100644
--- a/clang-tools-extra/clangd/ConfigCompile.cpp
+++ b/clang-tools-extra/clangd/ConfigCompile.cpp
@@ -439,8 +439,7 @@ struct FragmentCompiler {
[Normalized(std::move(Normalized))](const Params &, Config &C) {
if (C.Diagnostics.SuppressAll)
return;
- for (llvm::StringRef N : Normalized)
- C.Diagnostics.Suppress.insert(N);
+ C.Diagnostics.Suppress.insert_range(Normalized);
});
if (F.UnusedIncludes) {
diff --git a/clang-tools-extra/clangd/index/dex/Dex.cpp b/clang-tools-extra/clangd/index/dex/Dex.cpp
index 5643ba0c5e4ce..575a96a112979 100644
--- a/clang-tools-extra/clangd/index/dex/Dex.cpp
+++ b/clang-tools-extra/clangd/index/dex/Dex.cpp
@@ -181,8 +181,7 @@ std::unique_ptr<Iterator> Dex::createFileProximityIterator(
Sources[Path] = SourceParams();
auto PathURI = URI::create(Path).toString();
const auto PathProximityURIs = generateProximityURIs(PathURI.c_str());
- for (const auto &ProximityURI : PathProximityURIs)
- ParentURIs.insert(ProximityURI);
+ ParentURIs.insert_range(PathProximityURIs);
}
// Use SymbolRelevanceSignals for symbol relevance evaluation: use defaults
// for all parameters except for Proximity Path distance signal.
|
kuhar
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.