Skip to content

Commit 97de0ec

Browse files
committed
fixup! fixup! fixup! fixup! fixup! [docs] Update docs on code-review process
Restore a note on weekly pings.
1 parent 3d646d1 commit 97de0ec

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

llvm/docs/Contributing.rst

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,15 @@ will not be able to select reviewers in such a way, in which case you can still
102102
get the attention of potential reviewers by CC'ing them in a comment -- just
103103
@name them.
104104

105-
If you do not have commit access, please let people know during the review and
106-
someone should commit it on your behalf once it has been accepted. For more
107-
information on LLVM's code-review process, please see :doc:`CodeReview`.
105+
If you have received no comments on your patch for a week, you can request a
106+
review by 'ping'ing the GitHub PR with "Ping". The common courtesy 'ping' rate
107+
is once a week. Please remember that you are asking for valuable time from
108+
other professional developers. Finally, if you do not have commit access,
109+
please let people know during the review and someone should commit it on your
110+
behalf once it has been accepted.
111+
112+
For more information on LLVM's code-review process, please see
113+
:doc:`CodeReview`.
108114

109115
.. _commit_from_git:
110116

0 commit comments

Comments
 (0)