Skip to content

Commit 9fec0a0

Browse files
authored
[libclc] Disable external-calls testing for clspv targets (#127529)
These targets don't include all OpenCL builtins, so there will always be external calls in the final bytecode module. Fixes #127316.
1 parent 22ef210 commit 9fec0a0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

libclc/cmake/modules/AddLibclc.cmake

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,9 @@ function(add_libclc_builtin_set)
351351
add_custom_target( prepare-${obj_suffix} ALL DEPENDS ${obj_suffix} )
352352
set_target_properties( "prepare-${obj_suffix}" PROPERTIES FOLDER "libclc/Device IR/Prepare" )
353353

354-
# nvptx-- targets don't include workitem builtins
355-
if( NOT ARG_TRIPLE MATCHES ".*ptx.*--$" )
354+
# nvptx-- targets don't include workitem builtins, and clspv targets don't
355+
# include all OpenCL builtins
356+
if( NOT ARG_ARCH MATCHES "^(nvptx|clspv)(64)?$" )
356357
add_test( NAME external-calls-${obj_suffix}
357358
COMMAND ./check_external_calls.sh ${CMAKE_CURRENT_BINARY_DIR}/${obj_suffix} ${LLVM_TOOLS_BINARY_DIR}
358359
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} )

0 commit comments

Comments
 (0)