Skip to content

[libclc] Disable external-calls testing for clspv targets #127529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

[libclc] Disable external-calls testing for clspv targets #127529

merged 1 commit into from
Feb 18, 2025

Conversation

frasercrmck
Copy link
Contributor

These targets don't include all OpenCL builtins, so there will always be external calls in the final bytecode module.

Fixes #127316.

@frasercrmck
[libclc] Disable external-calls testing for clspv targets
3b172c6 
These targets don't include all OpenCL builtins, so there will always be
external calls in the final bytecode module.

Fixes llvm#127316.
@frasercrmck frasercrmck added the libclc libclc OpenCL library label Feb 17, 2025
@frasercrmck frasercrmck requested review from mgorny and nikic February 17, 2025 17:57
mgorny
mgorny approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frasercrmck frasercrmck merged commit 9fec0a0 into llvm:main Feb 18, 2025
10 checks passed
@frasercrmck frasercrmck deleted the libclc-fix-ctest-clspv branch February 18, 2025 09:14
@llvm-ci
Copy link
Collaborator

llvm-ci commented Feb 18, 2025

LLVM Buildbot has detected a new failure on builder premerge-monolithic-linux running on premerge-linux-1 while building libclc at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/23133

Here is the relevant piece of the build log for the reference 
Step 7 (test-build-unified-tree-check-all) failure: test (failure)
...
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Integer/sub-overflow.cpp (94352 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Integer/negate-overflow.cpp (94353 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Integer/no-recover.cpp (94354 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Integer/div-zero.cpp (94355 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Misc/Posix/sigaction.cpp (94356 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Integer/suppressions.cpp (94357 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Integer/uadd-overflow.cpp (94358 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Misc/Posix/ubsan_options.cpp (94359 of 98393)
PASS: UBSan-Standalone-lld-x86_64 :: TestCases/Misc/bool.cpp (94360 of 98393)
TIMEOUT: MLIR :: Examples/standalone/test.toy (94361 of 98393)
******************** TEST 'MLIR :: Examples/standalone/test.toy' FAILED ********************
Exit Code: 1
Timeout: Reached timeout of 60 seconds

Command Output (stdout):
--
# RUN: at line 1
"/etc/cmake/bin/cmake" "/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/examples/standalone" -G "Ninja"  -DCMAKE_CXX_COMPILER=/usr/bin/clang++  -DCMAKE_C_COMPILER=/usr/bin/clang   -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/build/buildbot/premerge-monolithic-linux/build/lib/cmake/mlir  -DLLVM_USE_LINKER=lld  -DPython3_EXECUTABLE="/usr/bin/python3.10"
# executed command: /etc/cmake/bin/cmake /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/examples/standalone -G Ninja -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/build/buildbot/premerge-monolithic-linux/build/lib/cmake/mlir -DLLVM_USE_LINKER=lld -DPython3_EXECUTABLE=/usr/bin/python3.10
# .---command stdout------------
# | -- The CXX compiler identification is Clang 16.0.6
# | -- The C compiler identification is Clang 16.0.6
# | -- Detecting CXX compiler ABI info
# | -- Detecting CXX compiler ABI info - done
# | -- Check for working CXX compiler: /usr/bin/clang++ - skipped
# | -- Detecting CXX compile features
# | -- Detecting CXX compile features - done
# | -- Detecting C compiler ABI info
# | -- Detecting C compiler ABI info - done
# | -- Check for working C compiler: /usr/bin/clang - skipped
# | -- Detecting C compile features
# | -- Detecting C compile features - done
# | -- Looking for histedit.h
# | -- Looking for histedit.h - found
# | -- Found LibEdit: /usr/include (found version "2.11") 
# | -- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11") 
# | -- Found LibXml2: /usr/lib/x86_64-linux-gnu/libxml2.so (found version "2.9.13") 
# | -- Using MLIRConfig.cmake in: /build/buildbot/premerge-monolithic-linux/build/lib/cmake/mlir
# | -- Using LLVMConfig.cmake in: /build/buildbot/premerge-monolithic-linux/build/lib/cmake/llvm
# | -- Linker detection: unknown
# | -- Performing Test LLVM_LIBSTDCXX_MIN
# | -- Performing Test LLVM_LIBSTDCXX_MIN - Success
# | -- Performing Test LLVM_LIBSTDCXX_SOFT_ERROR
# | -- Performing Test LLVM_LIBSTDCXX_SOFT_ERROR - Success
# | -- Performing Test CXX_SUPPORTS_CUSTOM_LINKER
# | -- Performing Test CXX_SUPPORTS_CUSTOM_LINKER - Success
# | -- Performing Test C_SUPPORTS_FPIC
# | -- Performing Test C_SUPPORTS_FPIC - Success
# | -- Performing Test CXX_SUPPORTS_FPIC

@frasercrmck
Copy link
Contributor Author

Just one failure:

********************
Timed Out Tests (1):
  MLIR :: Examples/standalone/test.toy

Total Discovered Tests: 131804
  Skipped          :     48 (0.04%)
  Unsupported      :   2855 (2.17%)
  Passed           : 128580 (97.55%)
  Expectedly Failed:    320 (0.24%)
  Timed Out        :      1 (0.00%)

I don't think this is related.

swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Feb 18, 2025
@frasercrmck @tstellar
[libclc] Disable external-calls testing for clspv targets (llvm#127529)
f567c03 
These targets don't include all OpenCL builtins, so there will always be
external calls in the final bytecode module.

Fixes llvm#127316.

(cherry picked from commit 9fec0a0)
wldfngrs pushed a commit to wldfngrs/llvm-project that referenced this pull request Feb 19, 2025
@frasercrmck @wldfngrs
[libclc] Disable external-calls testing for clspv targets (llvm#127529)
666fd9a 
These targets don't include all OpenCL builtins, so there will always be
external calls in the final bytecode module.

Fixes llvm#127316.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

@nikic nikic Awaiting requested review from nikic

Assignees
No one assigned
Labels
libclc libclc OpenCL library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libclc] clspv* tests are failing
3 participants
@frasercrmck @llvm-ci @mgorny